Sync eng/common directory with azure-sdk-tools for PR 12910 #6829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Copilot finished reviewing on behalf of
azure-sdk
November 15, 2025 00:14
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with changes from azure-sdk-tools PR #12910, updating the spell-checking pipeline template to add cspell upgrade verification functionality.
Key Changes:
- Converts parameter definitions to structured format with explicit name/type/default fields
- Adds new
EnableCspellUpgradeVerificationparameter to optionally enable cspell upgrade verification - Implements conditional logic to verify cspell upgrades when package-lock.json changes are detected
| - pwsh: | | ||
| if ('true' -eq '$(Skip.SpellCheck)') { | ||
| Write-Host "Spell check is skipped in this build. Skipping cspell upgrade verification." | ||
| Write-Host "##vso[task.setvariable variable=RunCspellUpgradeVerification]false" |
There was a problem hiding this comment.
The variable RunCspellUpgradeVerification is set but never used in the script. This variable assignment serves no purpose and should be removed to avoid confusion.
Suggested change
| Write-Host "##vso[task.setvariable variable=RunCspellUpgradeVerification]false" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12910 See eng/common workflow