Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Add the PathGetPropertiesAction getStatus on the Data Lake client getProperties request #43176

Open
2 tasks done
eduardotr-db opened this issue Dec 3, 2024 · 3 comments · May be fixed by #44463
Open
2 tasks done

[FEATURE REQ] Add the PathGetPropertiesAction getStatus on the Data Lake client getProperties request #43176

eduardotr-db opened this issue Dec 3, 2024 · 3 comments · May be fixed by #44463
Assignees
@ibrandes
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)

Comments

@eduardotr-db
Copy link

eduardotr-db commented Dec 3, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
My org is using Customer Provided Key encryption for the Azure Data Lake Storage service, and we rely on getting the x-ms-encryption-context header from files when we do a request to the service with the wrong encryption key as we use the value stored in this header to help derive the right key for the file.

In order to get this header, we use the Path Get Properties endpoint in the REST API and set the PathGetPropertiesAction query param as getStatus to retrieve this. Using this method we do not access the user data of the file and only get the system defined properties attached to it, hence encryption checks are not done.

Describe the solution you'd like
Expose a method in the DataLakePathClient class that sets the action=getStatus query param for the getProperties method:
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java#L1463-L1465

Describe alternatives you've considered
I explored all of the different getProperties methods exposed already but none are returning the header I need x-ms-encryption-context

Additional context
Add any other context or screenshots about the feature request here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files) labels Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

@ibrahimrabab @ibrandes @kyleknap @seanmcc-msft

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@eduardotr-db eduardotr-db changed the title [FEATURE REQ] [FEATURE REQ] Add the PathGetPropertiesAction getStatus on the Data Lake client getProperties request Dec 3, 2024
This was referenced Jan 9, 2025
Closed
Open
@ibrandes
Copy link
Contributor

ibrandes commented Mar 5, 2025

Hi @eduardotr-db,

We wanted to update you on our progress with this feature. Because the feature involves code generation and numerous public-facing changes, we had to adhere to several internal processes. As a result, we created a new PR with the changes you requested.

Additionally, the header error you encountered was caused by an old pipeline policy that validated the presence of the x-ms-encryption-key-sha256 request header when it was received in a response. We've implemented a workaround for this policy, so you shouldn't see this error anymore.

We apologize for the delay and any inconvenience caused. Your original PR was very useful in helping us understand your vision for the feature. Thank you for your patience, understanding, and for submitting the initial PR!

Please feel free to review the new PR and let us know if there's anything else you'd like to see :)

@ibrandes ibrandes assigned ibrandes and unassigned seanmcc-msft Mar 5, 2025
@ibrandes ibrandes linked a pull request Mar 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibrandes ibrandes

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

getSystemProperties Datalake feature ibrandes/azure-sdk-for-java
3 participants
@seanmcc-msft @ibrandes @eduardotr-db