Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the getStatus action in the Azure File Datalake getProperties API #43750

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

eduardotr-db
Copy link

Description

Implementing feature request: #43176

Support calling the getProperties API with the action=getStatus query param. This is for returning only system defined properties of the Path.

This is useful for us since it allows to read metadata of the file without requiring the CPK encryption key being set, allowing us to retrieve the proper encryption key on retries when a key rotation event happens.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files) labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thank you for your contribution @eduardotr-db! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-storage-file-datalake

@eduardotr-db eduardotr-db marked this pull request as ready for review January 9, 2025 12:36
@eduardotr-db
Copy link
Author

@seanmcc-msft and maintainers

It seems like I'm not doing the code change quite right (according to CI). I'm getting issues due to code generation although I'm not sure where the code generation is being done and also have test issues due to a header (although most of my code is the same as the getAccessControl method since I'm only changing the query param. I'd appreciate some guidance here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants