Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL]: Add RegionalRoutingContext to encapsulate URI. #44398

Merged
merged 18 commits into from
Mar 3, 2025
Merged

[INTERNAL]: Add RegionalRoutingContext to encapsulate URI. #44398

merged 18 commits into from
Mar 3, 2025

Conversation

nehrao1
Copy link
Member

@nehrao1 nehrao1 commented Feb 25, 2025 •
edited by jeet1995
Loading

Description

The objective of this PR is to add a RegionalRoutingContext which encapsulates a URI instance representing the gateway regional endpoint. This is in preparation to have RegionalRoutingContext also encapsulate the thin-client regional endpoint along with health state of these individual endpoints.

In the future, this will allow to transparently switch (w/o restarting clients) between using the thin-proxy endpoint and the Gateway endpoint in case of an issue with either.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nehrao1 nehrao1 requested review from kirankumarkolli and a team as code owners February 25, 2025 18:55
@nehrao1
Copy link
Member Author

nehrao1 commented Feb 25, 2025

/azp run java - cosmos - ci

@nehrao1
Copy link
Member Author

nehrao1 commented Feb 25, 2025

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nehrao1
Copy link
Member Author

nehrao1 commented Feb 25, 2025

/azp run java - cosmos - ci

@nehrao1
Copy link
Member Author

nehrao1 commented Feb 25, 2025

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel
FabianMeiswinkel requested changes Feb 25, 2025
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks good overall - just left a few questions/comments.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 26, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-cosmos

FabianMeiswinkel
FabianMeiswinkel approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for few minor comments

@jeet1995
Copy link
Member

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel
FabianMeiswinkel approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@jeet1995
Copy link
Member

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar
kushagraThapar approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions, thanks!

@jeet1995 jeet1995 changed the title Add RegionalEndpoints Abstraction Layer to LocationCache [INTERNAL]: Add RegionalRoutingContext to encapsulate URI. Mar 3, 2025
@jeet1995
Copy link
Member

jeet1995 commented Mar 3, 2025

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeet1995 jeet1995 enabled auto-merge (squash) March 3, 2025 22:25
@jeet1995 jeet1995 merged commit 9046fe6 into Azure:main Mar 3, 2025
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@jeet1995 jeet1995 Awaiting requested review from jeet1995

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nehrao1 @azure-sdk @jeet1995 @kushagraThapar @FabianMeiswinkel