Move V2 libraries to separate folder #44434
Conversation
alzimmermsft
requested review from
samvaity,
g2vinay,
JimSuplizio,
vcolin7,
srnagar,
JonathanGiles,
hallipr,
weshaggard,
benbp,
anuchandy,
lmolkova,
mssfang,
billwert,
joshfree and
conniey
as code owners
alzimmermsft
requested review from
rujche,
Netyyyy,
saragluna and
moarychan
as code owners
| @@ -36,13 +36,14 @@ function UpdateBomProjectElement($OldPomFilePath, $NewPomFilePath) { | |||
| Write-Output "InputDir:$($InputDir)" | |||
| Write-Output "OutputDir:$($OutputDir)" | |||
| Write-Output "Updating version_client.txt file by looking at the packages released to maven." | |||
| # TODO (alzimmer): Handle other group IDs for generating BOMs | |||
There was a problem hiding this comment.
please file a tracking Azure.Core.V2 issue for this and reference the issue number
| @@ -462,8 +462,8 @@ function Get-java-GithubIoDocIndex() | |||
| # Fetch out all package metadata from csv file. | |||
| $metadata = Get-CSVMetadata -MetadataUri $MetadataUri | |||
| # Leave the track 2 packages if multiple packages fetched out. | |||
| $clientPackages = $metadata | Where-Object { $_.GroupId -eq 'com.azure' } | |||
| $nonClientPackages = $metadata | Where-Object { $_.GroupId -ne 'com.azure' -and !$clientPackages.Package.Contains($_.Package) } | |||
| $clientPackages = $metadata | Where-Object { $_.GroupId -eq 'com.azure' -or $_.GroupId -eq 'com.azure.v2' } | |||
There was a problem hiding this comment.
it would be a good habit to start defining these groupIDs as constants at the top of scripts
| @@ -55,6 +55,7 @@ | |||
| <module>sdk/containerservicefleet</module> | |||
| <module>sdk/contentsafety</module> | |||
| <module>sdk/core</module> | |||
| <module>sdk/corev2</module> | |||
There was a problem hiding this comment.
Please update .github/CODEOWNERS at the same time as adding this
be sure to use the new Azure.Core.V2 label at the same time
# PRLabel: %Azure.Core.V2
/sdk/corev2/ .....
|
@alzimmermsft is there a reason you want with this path strategy? I know we haven't talked about but I was thinking a pattern like |
|
@weshaggard, the reason behind this change was to allow the V2 libraries to use their This should also help separate out V1 and V2 libraries from each other to make them easier to work on. They way main is right now if you want to work on Core V2 libraries you will also drag in Core V1 libraries as the module POM at the root of the SDK group includes both. And this should also simplify |
|
Closing this PR as it has moved to #44477 |
Description
Moves the
*-v2libraries undersdk/coretosdk/corev2to allow for those libraries to re-use the sameartifactIdbut under a differentgroupId(com.azure:azure-core->com.azure.v2:azure-core). This updates some engineering scripts to support the newgroupIdand leaves a few comments on where additional support will be needed in the future.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines