Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing AAD Audience from connection string #44482

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

harsimar
Copy link
Member

@harsimar harsimar commented Mar 4, 2025

Description

This PR adds support for parsing the AAD Audience from the connection string. If there isn't an audience provided, it will use the default audience and scope (https://monitor.azure.com//.default). This is so we can support AAD auth in sovereign clouds. The AzureMonitorExporterBuilder will call ConnectionString.getAadAudienceWithScope() so that the correct scope is used in http pipeline policies.

There will a PR added in ApplicationInsights-Java repo so that the java agent can also utilize this functionality.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Mar 4, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-monitor-opentelemetry-autoconfigure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants