Azure-Core Migration Recipes #44494
Draft
Azure-Core Migration Recipes #44494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In progress
In progress
…' into openrewrite/azure-core-migration
github-actions
bot
added
the
Azure SDK Tools
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
|
||
| public class HttpRequestExample { | ||
| public static void main(String... args) { | ||
| HttpClient client = new JdkHttpClientBuilder().build(); |
There was a problem hiding this comment.
This isn't right - we shouldn't be changing the customer code from using Netty to using JdkHttpClient
Comment on lines
+15
to
+20
| try { | ||
| Response response = client.send(request); | ||
| System.out.println("Status code: " + response.getStatusCode()); | ||
| } catch (IOException e) { | ||
| System.err.println("Error occurred: " + e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Is the try / catch required in vNext?
Comment on lines
+14
to
+15
| HttpHeaders headers = new HttpHeaders(); | ||
| headers.add(HttpHeaderName.CONTENT_TYPE, "multipart/form-data"); |
There was a problem hiding this comment.
Should follow the same pattern as before - HttpHeaders headers = new HttpHeaders().set("Content-Type", "multipart/form-data");
| String jsonBody = "{\"key\":\"value\"}"; | ||
| HttpRequest request = new HttpRequest(HttpMethod.PUT, "https://example.com", headers, jsonBody); | ||
|
|
||
| HttpResponse response = client.send(request).block(); |
There was a problem hiding this comment.
These samples are using the async pipeline and blocking. You'll want to make sure you also support the scenario where the sync pipeline was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the migration recipes and test for the migration of azure-core to clientcore and azure-core-v2.