Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another round of ClientCore API updates based on review #44531

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Another round of ClientCore API updates based on review #44531

merged 2 commits into from
Mar 7, 2025

Conversation

alzimmermsft
Copy link
Member

Description

Another PR containing API updates for ClientCore and Core V2 based on review of the API.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Mar 6, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

io.clientcore:annotation-processor

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 6, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

io.clientcore:annotation-processor
io.clientcore:core
io.clientcore:http-okhttp3
com.azure:azure-core-v2

@alzimmermsft alzimmermsft merged commit 5551f1b into Azure:main Mar 7, 2025
85 checks passed
@alzimmermsft
Copy link
Member Author

Follow-up issue for comments resolved without conclusion

#44553

@alzimmermsft alzimmermsft deleted the AzCC_AnotherRoundOfReview branch March 7, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core clientcore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @srnagar