Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype for simplifying Configuration in ClientCore #44565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alzimmermsft
Copy link
Member

Description

PR prototyping a simplified Configuration story for ClientCore.

This removes much of the code around Configuration and greatly simplifies the story to:

A Configuration is comprised of zero or more ConfigurationSources that load configurations from their implemented location. ConfigurationSources supplied to Configuration are queried in the order they're given until one returns a non-null value.

Two ConfigurationSources, EnvironmentVariableConfigurationSource and SystemPropertiesConfigurationSource which pull values from System.getenv(String) and System.getProperties(String) respectively. Configuration.getGlobalConfiguration() uses both with preferring system properties over environment variables. Configuration.none() is added which is a Configuration with no sources, therefore always returning null.

Configuration APIs have been simplified to just get(String name) and get(String name, String... aliases) for supporting single named configurations and configurations that have additional aliases we wish to check.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant