Prototype for simplifying Configuration in ClientCore #44565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR prototyping a simplified
Configuration
story for ClientCore.This removes much of the code around
Configuration
and greatly simplifies the story to:A
Configuration
is comprised of zero or moreConfigurationSource
s that load configurations from their implemented location.ConfigurationSource
s supplied toConfiguration
are queried in the order they're given until one returns a non-null value.Two
ConfigurationSource
s,EnvironmentVariableConfigurationSource
andSystemPropertiesConfigurationSource
which pull values fromSystem.getenv(String)
andSystem.getProperties(String)
respectively.Configuration.getGlobalConfiguration()
uses both with preferring system properties over environment variables.Configuration.none()
is added which is aConfiguration
with no sources, therefore always returning null.Configuration
APIs have been simplified to justget(String name)
andget(String name, String... aliases)
for supporting single named configurations and configurations that have additional aliases we wish to check.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines