[AutoPR azure-resourcemanager-keyvault]-generated-from-SDK Generation - Java-5500355 #47100

azure-sdk · 2025-10-27T06:14:45Z

Configurations: 'specification/keyvault/KeyVault.Management/tspconfig.yaml', API Version: 2025-05-01, SDK Release Type: stable, and CommitSHA: '0cb64d42641af4650a90a716afc321b3f0cb4057' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5500355 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

….yaml', API Version: 2025-05-01, SDK Release Type: stable, and CommitSHA: '0cb64d42641af4650a90a716afc321b3f0cb4057' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5500355 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

github-actions · 2025-10-27T06:32:56Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-keyvault

XiaofeiCao · 2025-10-28T06:40:46Z

...ger-keyvault/src/test/java/com/azure/resourcemanager/keyvault/generated/AttributesTests.java

Codegen issue logged: Azure/autorest.java#1861 (comment)

XiaofeiCao · 2025-10-31T02:37:31Z

...re-resourcemanager-keyvault/src/test/java/com/azure/resourcemanager/keyvault/VaultTests.java

-        String us = generateRandomResourceName("us", 20);
-        ServicePrincipal servicePrincipal
-            = authorizationManager.servicePrincipals().define(sp).withNewApplication().create();
+        //        String sp = generateRandomResourceName("sp", 20);
+        //        String us = generateRandomResourceName("us", 20);
+        // issue: https://github.com/Azure/azure-sdk-for-java/issues/47117
+        //        ServicePrincipal servicePrincipal
+        //            = authorizationManager.servicePrincipals().define(sp).withNewApplication().create();

-        ActiveDirectoryUser user
-            = authorizationManager.users().define(us).withEmailAlias(us).withPassword(password()).create();
+        // Status code 403, "{"error":{"code":"Authorization_RequestDenied","message":"Insufficient privileges to complete the operation."
+        //        ActiveDirectoryUser user
+        //            = authorizationManager.users().define(us).withEmailAlias(us).withPassword(password()).create();


Change to tests are mostly about this.

Application needs an additional serviceTreeID parameter: [FEATURE REQ] mgmt, authorization, support creating Application with serviceTreeID #47117

We don't have permission to create AAD user anymore.

XiaofeiCao · 2025-10-31T04:15:03Z

revapi error is not related to mgmt libraries

Copilot

Pull Request Overview

This PR updates the Azure Key Vault resource manager library from AutoRest to TypeSpec code generation, migrating from API version 2024-11-01 to 2025-05-01. The changes are primarily auto-generated code updates.

Updated code generator from AutoRest to TypeSpec
Updated API version from 2024-11-01 to 2025-05-01
Simplified example file references in sample code (removing full specification paths)
Added new test files for generated models
Modified test cases to use empty access policies instead of user/service principal-based policies
Updated module-info.java to expose implementation.models package

Reviewed Changes

Copilot reviewed 169 out of 288 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Sample files (43 files)	Updated code generator reference and simplified x-ms-original-file paths
Test files (80+ new files)	Added comprehensive test coverage for model serialization/deserialization
VaultTests.java	Modified to use empty access policies, commented out user/service principal code
Sku.java	Removed default value initialization for family field
ServiceSpecification.java	Changed from @fluent to @immutable, made constructor private, removed setters
PrivateLinkResource.java	Changed from Resource to ProxyResource base class, added SystemData field
PrivateEndpointConnectionsPutHeaders.java	Changed to @immutable with final fields, removed setters
Reason.java	Changed from enum to ExpandableStringEnum
ProvisioningState.java	Added JavaDoc comments for enum values
tsp-location.yaml	New file specifying TypeSpec source location
module-info.java	Opened implementation.models package to azure.core
Metadata and package-info files	Updated generator references and descriptions

Copilot · 2025-10-31T04:25:34Z

...re-resourcemanager-keyvault/src/main/java/com/azure/resourcemanager/keyvault/models/Sku.java

     * SKU family name
     */
-    private SkuFamily family = SkuFamily.A;
+    private SkuFamily family;


Removing the default value SkuFamily.A from the family field is a breaking change. Previously, this field had a default value, but now it will be null until explicitly set. This could break existing code that relies on the default value being present. Consider documenting this breaking change in the CHANGELOG and ensuring backward compatibility is addressed.

Copilot · 2025-10-31T04:25:34Z

...r-keyvault/src/main/java/com/azure/resourcemanager/keyvault/models/ServiceSpecification.java

     * Creates an instance of ServiceSpecification class.
     */
-    public ServiceSpecification() {
+    private ServiceSpecification() {


Changing the constructor from public to private is a breaking change that prevents instantiation of this class by consumers. This appears intentional as the class is now marked @immutable, but this should be documented as a breaking change in the CHANGELOG.

Copilot · 2025-10-31T04:25:34Z

...ain/java/com/azure/resourcemanager/keyvault/models/PrivateEndpointConnectionsPutHeaders.java

     * The Retry-After property.
     */
-    private Integer retryAfter;
+    private final Integer retryAfter;


Converting mutable fields to final fields and removing setters is a breaking change. Code that previously used withRetryAfter() or withAzureAsyncOperation() methods will no longer compile. This breaking change should be documented in the CHANGELOG.

Copilot · 2025-10-31T04:25:34Z

...ain/java/com/azure/resourcemanager/keyvault/models/PrivateEndpointConnectionsPutHeaders.java

     * The Azure-AsyncOperation property.
     */
-    private String azureAsyncOperation;
+    private final String azureAsyncOperation;


Converting mutable fields to final fields and removing setters is a breaking change. Code that previously used withRetryAfter() or withAzureAsyncOperation() methods will no longer compile. This breaking change should be documented in the CHANGELOG.

weidongxu-microsoft · 2025-10-31T04:41:50Z

...lt/src/main/java/com/azure/resourcemanager/keyvault/models/SecretsCreateOrUpdateHeaders.java

TypeSpec maybe wrong. We should not have retryAfter header for non-LRO.

Checked the secret data-plane lib, I think this is not LRO. And typically should not have this header in such API.
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/keyvault/azure-security-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java#L158-L178

github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 27, 2025

fix unreleased version in version_client.txt

3303fa1

XiaofeiCao added 3 commits October 27, 2025 14:42

remove unused unreleased entry

c91492a

module-info.java

bef5fbc

remove error generated tests

86b4492

XiaofeiCao reviewed Oct 28, 2025

View reviewed changes

XiaofeiCao assigned XiaofeiCao and v-huizhu2 Oct 28, 2025

XiaofeiCao and others added 7 commits October 29, 2025 14:01

regen

da734f3

fix tests

b0b444f

disable user creation

ecc8b74

revapi.json

8e4cd91

assets.json from Hui

59ef15b

record failed recordings, other fixes

2e4caa6

Merge branch 'main' into sdkauto/azure-resourcemanager-keyvault-5500355

0316bc1

XiaofeiCao reviewed Oct 31, 2025

View reviewed changes

XiaofeiCao added 3 commits October 31, 2025 10:47

fix changelog

e1c2109

update tsp-location.yaml, azure-resourcemanager changelog

3e63877

add back containerservice revapi

a6f478a

XiaofeiCao marked this pull request as ready for review October 31, 2025 04:15

Copilot AI review requested due to automatic review settings October 31, 2025 04:15

XiaofeiCao requested review from JonathanGiles, Netyyyy, alzimmermsft, rujche, saragluna and srnagar as code owners October 31, 2025 04:15

XiaofeiCao requested review from a team, ArthurMa1978, haolingdong-msft, moarychan and weidongxu-microsoft as code owners October 31, 2025 04:15

Copilot AI reviewed Oct 31, 2025

View reviewed changes

weidongxu-microsoft reviewed Oct 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AutoPR azure-resourcemanager-keyvault]-generated-from-SDK Generation - Java-5500355 #47100

[AutoPR azure-resourcemanager-keyvault]-generated-from-SDK Generation - Java-5500355 #47100

Uh oh!

azure-sdk commented Oct 27, 2025

Uh oh!

github-actions bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

XiaofeiCao Oct 28, 2025

Uh oh!

XiaofeiCao Oct 31, 2025 •

edited

Loading

Uh oh!

XiaofeiCao commented Oct 31, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 31, 2025

Uh oh!

Copilot AI Oct 31, 2025

Uh oh!

Copilot AI Oct 31, 2025

Uh oh!

Copilot AI Oct 31, 2025

Uh oh!

weidongxu-microsoft Oct 31, 2025

Uh oh!

weidongxu-microsoft Oct 31, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[AutoPR azure-resourcemanager-keyvault]-generated-from-SDK Generation - Java-5500355 #47100

Are you sure you want to change the base?

[AutoPR azure-resourcemanager-keyvault]-generated-from-SDK Generation - Java-5500355 #47100

Uh oh!

Conversation

azure-sdk commented Oct 27, 2025

Uh oh!

github-actions bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

XiaofeiCao Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

XiaofeiCao Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XiaofeiCao commented Oct 31, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

weidongxu-microsoft Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

weidongxu-microsoft Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 27, 2025 •

edited

Loading

XiaofeiCao Oct 31, 2025 •

edited

Loading

weidongxu-microsoft Oct 31, 2025 •

edited

Loading