-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Test spring boot 4 #47330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test spring boot 4 #47330
Conversation
…025.1.0-M4 Co-authored-by: Netyyyy <[email protected]>
…nonnull annotations Co-authored-by: Netyyyy <[email protected]>
Co-authored-by: Netyyyy <[email protected]>
…025.1.0-M4 (partial) Co-authored-by: Netyyyy <[email protected]>
| springboot3_org.springframework.boot:spring-boot-starter;3.5.5 | ||
| springboot3_org.springframework.boot:spring-boot-test;3.5.5 | ||
| springboot3_org.springframework.boot:spring-boot-testcontainers;3.5.5 | ||
| springboot3_org.springframework.boot:spring-boot-actuator-autoconfigure;4.0.0-RC2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change the prefix from
springboot3tospringboot4. - Change Spring Boot version from
4.0.0-RC2to4.0.0.
| springboot3_org.springframework.cloud:spring-cloud-bus;4.3.0 | ||
| springboot3_org.springframework.cloud:spring-cloud-context;4.3.0 | ||
| springboot3_org.springframework.cloud:spring-cloud-starter-stream-kafka;4.3.0 | ||
| springboot3_org.springframework.cloud:spring-cloud-starter-stream-kafka;5.0.0-RC1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Same here. Use release version instead of RC (Release Candidate) version.
- Is it right that
org.springframework.cloud:spring-cloud-starter-stream-kafkaupgraded the major version butorg.springframework.cloud:spring-cloud-busdidn't update the version?
sdk/spring/CHANGELOG.md
Outdated
| @@ -1,4 +1,6 @@ | |||
| # Release History | |||
| # (Unreleased) | |||
| Upgrade Spring Boot dependencies version to 4.0.0-RC2 and Spring Cloud dependencies version to 2025.1.0-M4 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-persistence</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only used for test. Please change to test scope.
sdk/spring/pom.xml
Outdated
| <enabled>false</enabled> | ||
| </snapshots> | ||
| </pluginRepository> | ||
| </pluginRepositories> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary anymore. Refs: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-4.0-Release-Notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark: Use 4.0.0 instead of 4.0.0-RC2
| * This is a special JWT Bearer flow implementation for Microsoft identify platform. | ||
| * | ||
| * @since 4.3.0 | ||
| * @see <a href="https://docs.microsoft.com/azure/active-directory/develop/v2-oauth2-on-behalf-of-flow">OAuth 2.0 On-Behalf-Of</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @since 4.3.0 is not right, it should be next release version.
| if (ClientAuthenticationMethod.CLIENT_SECRET_POST.equals(clientRegistration.getClientAuthenticationMethod())) { | ||
| parameters.add(OAuth2ParameterNames.CLIENT_ID, clientRegistration.getClientId()); | ||
| parameters.add(OAuth2ParameterNames.CLIENT_SECRET, clientRegistration.getClientSecret()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why above parameters are necessary since Spring Boot 4?
| if (ClientAuthenticationMethod.CLIENT_SECRET_POST.equals(clientRegistration.getClientAuthenticationMethod())) { | ||
| parameters.add(OAuth2ParameterNames.CLIENT_ID, clientRegistration.getClientId()); | ||
| parameters.add(OAuth2ParameterNames.CLIENT_SECRET, clientRegistration.getClientSecret()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the parameters like scope / client-id, client-secret, I guess the default converter in spring security also need to do this. Can we reuse the code in the default converter?
| if (this.sendCallback != null) { | ||
| this.sendCallback.onFailure(ex); | ||
| } | ||
| CompletableFuture<T> future = mono.toFuture(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's necessary to change from Mono to Future?
…framework.data.core.TypeInformation

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines