Skip to content

Conversation

@Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Nov 19, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Nov 19, 2025
springboot3_org.springframework.boot:spring-boot-starter;3.5.5
springboot3_org.springframework.boot:spring-boot-test;3.5.5
springboot3_org.springframework.boot:spring-boot-testcontainers;3.5.5
springboot3_org.springframework.boot:spring-boot-actuator-autoconfigure;4.0.0-RC2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change the prefix from springboot3 to springboot4.
  2. Change Spring Boot version from 4.0.0-RC2 to 4.0.0.

springboot3_org.springframework.cloud:spring-cloud-bus;4.3.0
springboot3_org.springframework.cloud:spring-cloud-context;4.3.0
springboot3_org.springframework.cloud:spring-cloud-starter-stream-kafka;4.3.0
springboot3_org.springframework.cloud:spring-cloud-starter-stream-kafka;5.0.0-RC1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Same here. Use release version instead of RC (Release Candidate) version.
  2. Is it right that org.springframework.cloud:spring-cloud-starter-stream-kafka upgraded the major version but org.springframework.cloud:spring-cloud-bus didn't update the version?

@@ -1,4 +1,6 @@
# Release History
# (Unreleased)
Upgrade Spring Boot dependencies version to 4.0.0-RC2 and Spring Cloud dependencies version to 2025.1.0-M4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-persistence</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used for test. Please change to test scope.

<enabled>false</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark: Use 4.0.0 instead of 4.0.0-RC2

* This is a special JWT Bearer flow implementation for Microsoft identify platform.
*
* @since 4.3.0
* @see <a href="https://docs.microsoft.com/azure/active-directory/develop/v2-oauth2-on-behalf-of-flow">OAuth 2.0 On-Behalf-Of</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @since 4.3.0 is not right, it should be next release version.

if (ClientAuthenticationMethod.CLIENT_SECRET_POST.equals(clientRegistration.getClientAuthenticationMethod())) {
parameters.add(OAuth2ParameterNames.CLIENT_ID, clientRegistration.getClientId());
parameters.add(OAuth2ParameterNames.CLIENT_SECRET, clientRegistration.getClientSecret());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why above parameters are necessary since Spring Boot 4?

if (ClientAuthenticationMethod.CLIENT_SECRET_POST.equals(clientRegistration.getClientAuthenticationMethod())) {
parameters.add(OAuth2ParameterNames.CLIENT_ID, clientRegistration.getClientId());
parameters.add(OAuth2ParameterNames.CLIENT_SECRET, clientRegistration.getClientSecret());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the parameters like scope / client-id, client-secret, I guess the default converter in spring security also need to do this. Can we reuse the code in the default converter?

if (this.sendCallback != null) {
this.sendCallback.onFailure(ex);
}
CompletableFuture<T> future = mono.toFuture();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's necessary to change from Mono to Future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants