[AzureMonitor] include LiveMetrics in Exporter project #48633
Conversation
TimothyMothra
requested review from
rajkumar-rangaraj and
xiang17
as code owners
github-actions
bot
added
Monitor - Distro
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Monitor.OpenTelemetry.AspNetCore |
TimothyMothra
requested review from
nisha-bhatia,
JoshLove-msft and
a team
as code owners
TimothyMothra
requested review from
joshfree,
pvaneck,
KevinBlasko,
KarishmaGhiya,
srnagar,
jairmyree and
gulopesd
| ServiceCallFailedWithServiceError(name: "Post", statusCode, serviceError.Code, serviceError.Exception, serviceError.Message); | ||
| } | ||
| } | ||
| //[NonEvent] |
There was a problem hiding this comment.
why are public APIs commented out? Is this a breaking change?
There was a problem hiding this comment.
@lmolkova could you review the PR please - thanks!
There was a problem hiding this comment.
0 public apis are affected here. We're moving the LiveMetrics feature from one package to the other. While juggling references, it's been easier to comment out blocks and address in a follow up PR.
The line you commented on is the EventSource class, used for internal logging inside our package. I have another PR already created to refactor and resolve misc issues with these classes.
Follow up to #48498.
This PR makes the LiveMetrics implementation available to the Exporter project.
To avoid conflicts, this also temporarily removes LiveMetrics from the Distro project.
This will be re-enabled in following PRs.