[AzureMonitor] refactor EventSource after LiveMetrics move #48640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
requested review from
rajkumar-rangaraj and
xiang17
as code owners
github-actions
bot
added
Monitor - Distro
|
API change check API changes are not detected in this pull request. |
| @@ -54,8 +54,8 @@ public static ConnectionVars GetValues(string connectionString) | |||
| AzureMonitorExporterEventSource.Log.FailedToParseConnectionString(ex); | |||
| #elif ASP_NET_CORE_DISTRO | |||
| AzureMonitorAspNetCoreEventSource.Log.FailedToParseConnectionString(ex); | |||
| #else | |||
| System.Diagnostics.Debug.Write(ex.ToString()); | |||
| #elif LIVE_METRICS_PROJECT | |||
There was a problem hiding this comment.
Recommend just using else here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #48498.
This PR cleans up EventSource classes.
We decided that the LiveMetrics project would have it's own EventSource class that gets included in the other project.
This removes most of the preprocessors needed in the previous PR.
Shared files in the Exporter project still need to call EventSource classes for logging. This could be improved on at a later date.
Any EventSource method not used by that project has been removed.