Storage STG 99 #49887
Merged
Storage STG 99 #49887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews Azure.Storage.Blobs |
|
/azp run net - storage - ci |
|
No pipelines are associated with this pull request. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Storage.Blobs |
* Storage Error Codes for Copies * fixed CI * recorded some tests * Pattern matched StartCopyAsync_SourceErrorAndStatusCode with blobs test * Refactored and recorded StartCopyAsync_SourceErrorAndStatusCode * re-recorded tests * Updated autorest * generate code
* Generated Swagger changes for ShareSnapshotNotFoundValue added in ShareErrorCode * Fixed autorest.md * fixed autorest.md * exported apis * ShareClient.DeleteIfExists catches ShareSnapshotNotFound * tiny test fix * autorest + recorded tests * Recorded test
…9000) * Changed QueueProperties.ApproximateMessagesCount from int to long * Changed autorest.md + exported api * Fixed autorest * Removed comments * Changed to throw OverflowException if ApproximateMessagesCount overflows * added breakingchange * addressed arch board feedback * Modified test * Updated autorest * generate code
seanmcc-msft
requested review from
amnguye,
jaschrep-msft,
tg-msft,
jalauzon-msft and
nickliu-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SDK to support service version 2025-11-05 while also adjusting error response expectations in various tests. Key changes include:
- Updating test assertions across multiple client test files to reflect the new error status codes and messages.
- Updating API defaults and making the AccountName property virtual to improve mockability.
- Bumping package versions and updating changelog entries and asset tags accordingly.
Reviewed Changes
Copilot reviewed 88 out of 88 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/Azure.Storage.Blobs/tests/PageBlobClientTests.cs | Updated test assertions for UploadPagesFromUriAsync error handling. |
| sdk/storage/Azure.Storage.Blobs/tests/ContainerClientTests.cs | Refactored error code string usage and added an InvalidServiceVersion test. |
| sdk/storage/Azure.Storage.Blobs/tests/BlockBlobClientTests.cs | Revised error assertions and modified SyncUploadFromUriAsync parameter. |
| sdk/storage/Azure.Storage.Blobs/tests/BlobBaseClientTests.cs | Removed ignored tests and updated error message validations. |
| sdk/storage/Azure.Storage.Blobs/tests/AppendBlobClientTests.cs | Updated error response validations for AppendBlockFromUriAsync. |
| sdk/storage/Azure.Storage.Blobs/src/autorest.md | Updated the input API version URL for Autorest generation. |
| sdk/storage/Azure.Storage.Blobs/src/BlobServiceClient.cs | Made the AccountName property virtual per design requirements. |
| sdk/storage/Azure.Storage.Blobs/src/BlobClientOptions.cs | Added support for the new service version V2025_11_05. |
| sdk/storage/Azure.Storage.Blobs/*.csproj; assets.json; API files; CHANGELOG.md; ChangeFeed tests; Blobs.Batch files | Bumped versions, updated configuration settings, and documented new features and breaking changes. |
Comments suppressed due to low confidence (3)
sdk/storage/Azure.Storage.Blobs/tests/BlockBlobClientTests.cs:2919
- Review the change from using GenerateSasUri() to directly passing sourceBlob.Uri to ensure the test still simulates the intended authentication error scenario.
destBlob.SyncUploadFromUriAsync(sourceBlob.Uri),
sdk/storage/Azure.Storage.Blobs/tests/PageBlobClientTests.cs:3415
- Ensure that the updated expected error code 401 and associated error details accurately reflect the backend service behavior across all environments.
Assert.IsTrue(e.Message.Contains("CopySourceStatusCode: 401"));
sdk/storage/Azure.Storage.Blobs/tests/BlobBaseClientTests.cs:3475
- Confirm that the updated error expectations (401 along with the new error code and message) are consistent with the documented service behavior.
Assert.IsTrue(e.Message.Contains("CopySourceStatusCode: 401"));
nickliu-msft
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.