MPG migration - impactreporting #54306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the ImpactReporting SDK to use the new Management Plane Generator (MPG). The migration updates the generator configuration and regenerates all SDK code with the new generator version.
Key Changes:
- Updated the generator configuration to use the new
azure-typespec-http-client-csharp-mgmt-emitter-package.json - Updated the spec commit reference from
0adbc7c8b375ab44b413bf71c9c9eabc383c5720toe7837338dc24a6fc1582d43c7721957c0eb9701b - Regenerated all SDK code with modernized patterns including improved serialization, updated documentation formatting, and refined code structure
Reviewed changes
Copilot reviewed 2 out of 110 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updated generator configuration to use new MPG emitter package and updated spec commit |
| Sample_ImpactConnectorCollection.cs | Updated test sample to include additional parameters in ImpactConnectorProperties constructor |
| WorkloadImpactResource.cs | Modernized resource class with updated serialization patterns, diagnostic scopes, and method signatures |
| WorkloadImpactResource.Serialization.cs | Updated serialization implementation with improved pattern consistency |
| WorkloadImpactData.cs | Simplified data model with cleaner field tracking and updated documentation |
| WorkloadImpactData.Serialization.cs | Modernized serialization with helper methods and improved deserialization |
| WorkloadImpactCollection.cs | Updated collection class with new diagnostic patterns and request handling |
| RestOperations/* | Simplified REST operation classes removing redundant methods and improving structure |
| Models/* | Updated all model classes with consistent serialization patterns and improved documentation |
| ProviderConstants.cs | File removed as part of generator migration |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
haiyuazhang
force-pushed
the
haiyzhan/impactreporting
branch
from
f05234b to
8e626ae
Compare
haiyuazhang
force-pushed
the
haiyzhan/impactreporting
branch
from
83d6298 to
678a065
Compare
ArthurMa1978
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.