Add run_command abstraction to azure_identity

sdk/identity/azure_identity/Cargo.toml

@@ -25,9 +25,7 @@ async-trait.workspace = true
 openssl = { workspace = true, optional = true }
 pin-project.workspace = true
 typespec_client_core = { workspace = true, features = ["derive"] }
-
-[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
-async-process.workspace = true
+tokio = { workspace = true, optional = true }
 
 [target.'cfg(unix)'.dependencies]
 tz-rs = { workspace = true, optional = true }
@@ -46,6 +44,7 @@ default = ["reqwest", "old_azure_cli"]
 reqwest = ["azure_core/reqwest"]
 reqwest_rustls = ["azure_core/reqwest_rustls"]
 client_certificate = ["openssl"]
+tokio_process = ["tokio"]
 
 # If you are using and Azure CLI version older than 2.54.0 from November 2023,
 # upgrade your Azure CLI version or enable this feature.

sdk/identity/azure_identity/src/credentials/azure_cli_credentials.rs

@@ -1,8 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-use crate::credentials::cache::TokenCache;
-use async_process::Command;
+use crate::{credentials::cache::TokenCache, run_command::run_command};
 use azure_core::{
     credentials::{AccessToken, Secret, TokenCredential},
     error::{Error, ErrorKind, ResultExt},
@@ -193,7 +192,7 @@ impl AzureCliCredential {
             args.join(" "),
         );
 
-        match Command::new(program).args(args).output().await {
+        match run_command(program, args).await {
             Ok(az_output) if az_output.status.success() => {
                 let output = str::from_utf8(&az_output.stdout)?;
 

sdk/identity/azure_identity/src/lib.rs

@@ -3,6 +3,8 @@
 
 #![doc = include_str!("../README.md")]
 
+mod run_command;
+
 mod authorization_code_flow;
 mod credentials;
 mod env;

sdk/identity/azure_identity/src/run_command/mod.rs

@@ -0,0 +1,38 @@
+use std::io::Error;
+use std::{ffi::OsStr, process::Output};
+
+#[cfg(feature = "tokio_process")]
+pub(crate) async fn run_command<S, I, A>(program: S, args: I) -> Result<Output, Error>
+where
+    S: AsRef<OsStr>,
+    I: IntoIterator<Item = A>,
+    A: AsRef<OsStr>,
+{
+    tokio::process::Command::new(program)
+        .args(args)
+        .output()
+        .await
+}
+
+#[cfg(not(feature = "tokio_process"))]
+pub(crate) async fn run_command<S, I, A>(program: S, args: I) -> Result<Output, Error>
+where
+    S: AsRef<OsStr>,
+    I: IntoIterator<Item = A>,
+    A: AsRef<OsStr>,
+{
+    use futures::channel::oneshot;
+    use std::io::ErrorKind;
+
+    let (tx, rx) = oneshot::channel();
+    let mut cmd = std::process::Command::new(program);
+    cmd.args(args);
+    std::thread::spawn(move || {
+        let output = cmd.output();
+        tx.send(output)
+    });
+    let output = rx
+        .await
+        .map_err(|err| Error::new(ErrorKind::Other, err))??;
+    Ok(output)
+}