Enable autobaselining only for rust - core
#2189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallipr
requested review from
weshaggard,
heaths,
RickWinter,
JeffreyRichter and
LarryOsterman
as code owners
weshaggard
reviewed
Feb 18, 2025
eng/pipelines/templates/jobs/ci.yml
Outdated
| paths: | ||
| - "/*" | ||
| - ${{ else }}: | ||
| - checkout: self |
There was a problem hiding this comment.
As we chatted I don't think this should be needed.
There was a problem hiding this comment.
I'm still unsure. SDL Baselining does require the github token and sparse checkout doesn't set the variable
There was a problem hiding this comment.
None of the other repos need to by-pass sparse-checkout so you shouldn't need to either. If we need to do it for this support we should do it consistently.
There was a problem hiding this comment.
Meaning we should have the other repos do it to or that we should always using native checkout here?
There was a problem hiding this comment.
No we should always do the sparse-checkout.
hallipr
force-pushed
the
users/pahallis/baselining
branch
from
34f3f88 to
203625b
Compare
weshaggard
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.