[Storage] stage_block, commit_block_list for BlobClient, get_container_properties for ContainerClient, get_service_properties for ServiceClient
#2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
commented
Mar 4, 2025
sdk/storage/azure_storage_blob/src/models/container_properties.rs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,23 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Do we really need/want a whole new crate for these helpers?
There was a problem hiding this comment.
Hmm, I was following the convention that:
- azure_core_test exists for test utilities for client libraries built on
azure_core - azure_security_keyvault_test exists for test utilities for
KeyVaulttests
I am happy to move these into the main azure_storage_blob crate, but we should check with Azure SDK what is idiomatic here.
There was a problem hiding this comment.
IMO this should probably be a helper sub-module in the test module of the SDK itself. The core test package provides all the stuff for other packages so that makes sense and keyvault has some actual tests in there so I don't think plain utilities have a precedent here.
Curious on Heath's thoughts though.
vincenttran-msft
requested review from
heaths,
RickWinter,
JeffreyRichter,
LarryOsterman and
ronniegeraghty
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following:
BlobClient
stage_blockcommit_block_listContainerClient
get_container_propertiesServiceClient
ServiceClientget_service_propertiesThis PR also moves to the standardized way to fetch randomized seeded names (
random_string) and includes a helper utility for test setup.