[Storage] Initial v11 codegen output
#2287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
commented
Mar 5, 2025
Comment on lines
+55
to
+62
| let client = GeneratedBlobClient::new( | ||
| endpoint, | ||
| credential.clone(), | ||
| "2025-05-05".to_string(), | ||
| container_name.clone(), | ||
| blob_name.clone(), | ||
| Some(options), | ||
| )?; |
There was a problem hiding this comment.
Now that we that we don't have an accessor BlobClient and this literally the generated client that will perform the REST operations, I think this makes some fields redundant on our handwritten clients.
Generated BlobClient struct:
pub struct BlobClient {
pub(crate) blob: String,
pub(crate) container_name: String,
pub(crate) endpoint: Url,
pub(crate) pipeline: Pipeline,
pub(crate) version: String,
}We can now omit blob_name, container_name, endpoint from the handwritten client layer and instead do self.client.<field>
There was a problem hiding this comment.
Omit from struct, add getters (that will go 1 layer down into gen client)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling, but testcases not adjusted yet. Have some points to discuss