[Storage] Add StorageError model type
#3011
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc: @heaths Heath, any pointers here on how to proceed with accessing the raw response on an Error response. Thanks! |
heaths
reviewed
Sep 22, 2025
vincenttran-msft
changed the title
StorageError model type
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
…al, exhaustively match possible XML value nodes
heaths
requested changes
Nov 24, 2025
| @@ -120,7 +119,7 @@ impl StorageError { | |||
| additional_fields: HashMap<String, Value>, | |||
| } | |||
|
|
|||
| let xml_fields = azure_core::xml::read_xml::<StorageErrorXml>(xml_body)?; | |||
| let xml_fields = xml::from_xml::<_, StorageErrorXml>(xml_body)?; | |||
Member
There was a problem hiding this comment.
Why are you passing the XML body and the raw_response? That's all available via raw_response.body().xml(). Also, if you're just getting data out of the raw body to format, borrow strings for memory efficiency: https://serde.rs/lifetimes.html#borrowing-data-in-a-derived-impl. We do this for Azure standard errors. Don't waste memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdout for
test_storage_error_model: