Skip to content

Conversation

@LarryOsterman
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 2, 2025 23:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the "cplusplus" feature to "ffi" throughout the azure_core_amqp crate to better align with Rust naming conventions. The Foreign Function Interface (FFI) feature provides functionality for serialization and deserialization of AMQP types, which is more accurately described as FFI rather than being C++-specific.

Key changes:

  • Updated all #[cfg(feature = "cplusplus")] directives to use "ffi" instead
  • Modified the feature definition in Cargo.toml
  • Added changelog entry documenting the breaking change

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/core/azure_core_amqp/src/value.rs Updated feature gates from "cplusplus" to "ffi" for AmqpComposite types and serialization traits
sdk/core/azure_core_amqp/src/messaging.rs Updated feature gates for FFI-related implementations of AMQP messaging types
sdk/core/azure_core_amqp/src/lib.rs Updated feature gates for Serializable and Deserializable traits and exports
sdk/core/azure_core_amqp/src/fe2o3/value.rs Updated feature gates for AmqpComposite handling in fe2o3 integration
sdk/core/azure_core_amqp/Cargo.toml Renamed the feature definition from "cplusplus" to "ffi"
sdk/core/azure_core_amqp/CHANGELOG.md Added changelog entry documenting the breaking change

@github-actions github-actions bot added the Azure.Core The azure_core crate label Oct 2, 2025
@heaths heaths merged commit 2130213 into Azure:main Oct 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core The azure_core crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants