[Azure.ClientSdk.Analyzers] Refine AZC0030

[jorgerangel-msft]

This PR introduces fixes for these items:

• Refine AZC0030 Error Message Regarding Options Suffix
  • The analyzer that was validating models with the Options suffix was updated to include a general diagnostic message which links to our guidelines regarding naming models. It will no longer suggest a name to use as a replacement.
• Update AZC0030 so that it doesn't prevent clients from having serializable models with the Options suffix.
  • The analyzer that was validating models with the Options suffix was scoped down to management plane models.

sdk-for-net test pr: Azure/azure-sdk-for-net#48597

[jorgerangel-msft]

Since we want a different behavior for when a model is suffixed with "Options", I've split that functionality into this new class which still shares the original diagnostic ID with GeneralSuffixAnalyzer. My main motivation was to reduce the blast radius of this change, in the case that users have suppressed the original diagnostic ID. If we feel like these changes warrant a new ID, it should be setup to easily do so.

[jsquire]

Good thinking.

[jsquire]

Good thinking.

[jsquire]

This pattern will allocate each time the property is called. Since the underlying array is immutable, we should be able to share the same instance.

Suggested change

	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get { return ImmutableArray.Create(Descriptors.AZC0030); } }
	public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =
	ImmutableArray.Create(Descriptors.AZC0030);

[jsquire]

Suggested change

	if ($"{fullNamespace}".Equals(AzureResourceManagerNamespaceName)
	|| $"{fullNamespace}".StartsWith($"{AzureResourceManagerNamespaceName}."))
	{
	return true;
	}
	return false;
	return ($"{fullNamespace}".Equals(AzureResourceManagerNamespaceName)
	|| $"{fullNamespace}".StartsWith($"{AzureResourceManagerNamespaceName}."));