Added minimal-py312-cuda11.8-inference environment #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarun-Chevula
had a problem deploying
to
Testing
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| except Exception as e: | ||
| error = str(e) | ||
|
|
||
| return AMLResponse({'error': error}, 500, json_str=True) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 3 days ago
To fix the problem, we should avoid exposing detailed error messages to the end user. Instead, we can log the detailed error message on the server and return a generic error message to the client. This approach ensures that sensitive information is not exposed while still allowing developers to access the necessary details for debugging.
- Modify the exception handling block to log the detailed error message.
- Return a generic error message to the client.
Suggested changeset
1
assets/inference/environments/minimal-py312-cuda11.8-inference/tests/src/valid_score.py
| @@ -31,4 +31,6 @@ | ||
| except Exception as e: | ||
| error = str(e) | ||
|
|
||
| return AMLResponse({'error': error}, 500, json_str=True) | ||
| error_message = str(e) | ||
| # Log the detailed error message | ||
| print(f"Error occurred: {error_message}") | ||
| # Return a generic error message to the client | ||
| return AMLResponse({'error': 'An internal error has occurred.'}, 500, json_str=True) |
Copilot is powered by AI and may make mistakes. Always verify output.
Tarun-Chevula
had a problem deploying
to
Testing
GitHub Actions
Failure
vizhur
requested changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added minimal-py312-cuda11.8-inference environment