Fix bug where microphone error shows twice #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carocao-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
edwardlee-msft
approved these changes
Feb 27, 2025
| @@ -76,14 +76,15 @@ export const errorBarSelector: ErrorBarSelector = createSelector( | |||
| if (deviceManager.deviceAccess?.audio === false && isSafari()) { | |||
| activeErrorMessages.push({ type: 'callMicrophoneAccessDeniedSafari' }); | |||
| } | |||
| if (deviceManager.deviceAccess?.audio === false && !isSafari()) { | |||
| if ( | |||
There was a problem hiding this comment.
nit: this would be better moved to an else if on the below if (diagnostics?.media.latest.microphonePermissionDenied?.value === true && isMacOS()) {
so it's clear that this condition is we don't push two microphone active errors
JamesBurnside
approved these changes
Feb 28, 2025
Chat bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix bug where microphone error shows twice
Why
How Tested
Process & policy checklist
Is this a breaking change?