-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change aria label of video effects radio button to begin with button title #5673
Open
mgamis-msft
wants to merge
3
commits into
main
Choose a base branch
from
mgamis/start-effects-radio-button-with-button-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Change aria label of video effects radio button to begin with button title #5673
mgamis-msft
wants to merge
3
commits into
main
from
mgamis/start-effects-radio-button-with-button-text
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-isseqrranc.chromatic.com/ |
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-twyvvpjzlv.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
dmceachernmsft
approved these changes
Feb 28, 2025
edwardlee-msft
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change aria label of video effects radio button to begin with button title then its tooltip content
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3906355
How Tested
Tested locally
Process & policy checklist
Is this a breaking change?