Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change aria label of video effects radio button to begin with button title #5673

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mgamis-msft
Copy link
Contributor

What

Change aria label of video effects radio button to begin with button title then its tooltip content

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3906355

How Tested

Tested locally

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1777281
  • Base size: 1777281
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28056 / 44676
62.79%
28056 / 44676
62.79%
786 / 1436
54.73%
2352 / 3724
63.15%
Current 28005 / 44676
62.68%
28005 / 44676
62.68%
786 / 1436
54.73%
2367 / 3729
63.47%
Diff -51 / 0
-0.11%
-51 / 0
-0.11%
0 / 0
0%
15 / 5
0.32%

Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58201 / 94221
61.77%
58201 / 94221
61.77%
1177 / 2693
43.7%
3498 / 5805
60.25%
Current 58225 / 94221
61.79%
58225 / 94221
61.79%
1177 / 2693
43.7%
3511 / 5809
60.44%
Diff 24 / 0
0.02%
24 / 0
0.02%
0 / 0
0%
13 / 4
0.19%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants