Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FHL] Accessibility Provider #5679

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

dmceachernmsft
Copy link
Member

@dmceachernmsft dmceachernmsft commented Mar 3, 2025

What

Adds a new A11y provider to the composites to use to track the last used control at all times so you can focus on the dismiss of a menu
image

Why

Allows more control over where the focus goes when we dismiss temporary controls so we never accidentally lose focus on the page

FHL - Lets see what happens...

How Tested

Testing locally, demo to come...

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Copy link
Contributor

github-actions bot commented Mar 6, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28076 / 44693
62.81%
28076 / 44693
62.81%
786 / 1436
54.73%
2332 / 3714
62.78%
Current 28142 / 44774
62.85%
28142 / 44774
62.85%
787 / 1440
54.65%
2356 / 3726
63.23%
Diff 66 / 81
0.04%
66 / 81
0.04%
1 / 4
-0.08%
24 / 12
0.45%

Copy link
Contributor

github-actions bot commented Mar 6, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58245 / 94265
61.78%
58245 / 94265
61.78%
1178 / 2693
43.74%
3490 / 5800
60.17%
Current 58354 / 94383
61.82%
58354 / 94383
61.82%
1179 / 2699
43.68%
3528 / 5824
60.57%
Diff 109 / 118
0.04%
109 / 118
0.04%
1 / 6
-0.06%
38 / 24
0.4%

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Copy link
Contributor

github-actions bot commented Mar 7, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Chat bundle size is increased❗.

  • Current size: 1777985
  • Base size: 1777647
  • Diff size: 338

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant