draft of modality specific usePropsFor functions #5684
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkwa-msft
requested review from
JamesBurnside,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hkqerigezz.chromatic.com/ |
| } | ||
| }; | ||
|
|
||
| export const useCallingPropsFor = <Component extends (props: any) => JSX.Element>( |
There was a problem hiding this comment.
Instead of recreating these in the mergedHooks, reexport them in the index.ts directly from the packlets
| } | ||
|
|
||
| if (!chatSelector) { | ||
| throw "Can't find corresponding selector for this component. Please check the supported components from Azure Communication UI Feature Component List."; |
There was a problem hiding this comment.
For an error like this is there a link we can provide to storybook?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We want to make separate exposed usePropsFor functions for Chat and Calling individually. This is because if you use the top-level usePropsFor function you will pull in all of the code and negate any opportunity for tree shaking. This is more of a problem when utilizing the Chat UI code and unfortunately pulling in all of the Calling code as well when using this function.
Is this a breaking change?
No, its an additive change.