Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up Rich Text Editor location in storybook #5687

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

emlynmac
Copy link
Member

@emlynmac emlynmac commented Mar 6, 2025

What

Ensure RTE is under the 'Message Thread' folder in storybook

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

@JoshuaLai
Copy link
Member

I think we need to fix up the story
image
There are no controls set up for the story, and even in the message thread itself, it doesn't look like it is using the rich text editor.

@emlynmac emlynmac added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Mar 6, 2025
@emlynmac emlynmac enabled auto-merge (squash) March 6, 2025 23:30
@emlynmac
Copy link
Member Author

emlynmac commented Mar 6, 2025

I think we need to fix up the story image There are no controls set up for the story, and even in the message thread itself, it doesn't look like it is using the rich text editor.

Please raise an issue for this @JoshuaLai

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Copy link
Contributor

github-actions bot commented Mar 6, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28079 / 44693
62.82%
28079 / 44693
62.82%
786 / 1436
54.73%
2355 / 3727
63.18%
Current 28020 / 44693
62.69%
28020 / 44693
62.69%
786 / 1436
54.73%
2322 / 3703
62.7%
Diff -59 / 0
-0.13%
-59 / 0
-0.13%
0 / 0
0%
-33 / -24
-0.48%

Copy link
Contributor

github-actions bot commented Mar 6, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58254 / 94265
61.79%
58254 / 94265
61.79%
1178 / 2693
43.74%
3545 / 5832
60.78%
Current 58302 / 94265
61.84%
58302 / 94265
61.84%
1178 / 2693
43.74%
3535 / 5832
60.61%
Diff 48 / 0
0.05%
48 / 0
0.05%
0 / 0
0%
-10 / 0
-0.17%

@emlynmac emlynmac removed the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Chat bundle size is not changed.

  • Current size: 1777647
  • Base size: 1777647
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Copy link
Member

@palatter palatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emlynmac emlynmac merged commit 6ad1e1a into main Mar 7, 2025
41 checks passed
@emlynmac emlynmac deleted the emlyn/storybook-fix-header branch March 7, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants