Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Remove node versions from storybook #5691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BugFix] Remove node versions from storybook #5691

wants to merge 1 commit into from

Conversation

dmceachernmsft
Copy link
Member

What

Remove the reference to specific node versions in storybook

Why

To encourage developers to use the LTS of node when working with the UI Library

https://skype.visualstudio.com/SPOOL/_workitems/edit/4051730

How Tested

Removed and inspected locally

@dmceachernmsft dmceachernmsft requested review from a team as code owners March 7, 2025 20:08
@dmceachernmsft dmceachernmsft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Mar 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Chat bundle size is not changed.

  • Current size: 1777647
  • Base size: 1777647
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ntcrfpgqux.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28076 / 44693
62.81%		 28076 / 44693
62.81%		 786 / 1436
54.73%		 2332 / 3714
62.78%
Current 28033 / 44693
62.72%		 28033 / 44693
62.72%		 786 / 1436
54.73%		 2353 / 3722
63.21%
Diff -43 / 0
-0.09%		 -43 / 0
-0.09%		 0 / 0
0%		 21 / 8
0.43%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58245 / 94265
61.78%		 58245 / 94265
61.78%		 1178 / 2693
43.74%		 3490 / 5800
60.17%
Current 58278 / 94265
61.82%		 58278 / 94265
61.82%		 1178 / 2693
43.74%		 3568 / 5845
61.04%
Diff 33 / 0
0.04%		 33 / 0
0.04%		 0 / 0
0%		 78 / 45
0.87%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees

@mgamis-msft mgamis-msft

@edwardlee-msft edwardlee-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmceachernmsft @mgamis-msft @edwardlee-msft