Skip to content

Update text references from Gateway / Logic Apps to Connector Namespace#27

Merged
manvkaur merged 10 commits into
mainfrom
manvkaur/fix-single-item-trigger-payload
May 27, 2026
Merged

Update text references from Gateway / Logic Apps to Connector Namespace#27
manvkaur merged 10 commits into
mainfrom
manvkaur/fix-single-item-trigger-payload

Conversation

@manvkaur

@manvkaur manvkaur commented May 19, 2026

Copy link
Copy Markdown
Contributor

This pull request updates documentation and samples to reflect the transition from "Connector Gateway" to "Connector Namespace" terminology and APIs across the SDK. It also improves clarity on connection setup, usage, and support resources, and adds references to new related SDKs.

Major terminology and API updates:

  • All references to "Connector Gateway" have been replaced with "Connector Namespace" in documentation, skill files, and sample prerequisites, including ARM API paths and portal names. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • The .github/skills/connection-setup/SKILL.md and docs/connection-setup.md files now consistently use "Connector Namespace" for setup instructions, resource creation, and OAuth consent. [1] [2] [3] [4] [5] [6] [7]

Documentation and roadmap improvements:

  • The roadmap (ROADMAP.md) and support docs have been updated to reflect the Connector Namespace resource and its GA status, removing outdated references to Logic Apps and Gateway. [1] [2] [3] [4] [5] [6]
  • The README and skill files clarify supported scenarios, add next steps for triggers and SDK usage, and reference additional SDKs (Node.js, .NET). [1] [2]

Repository and support resource cleanup:

  • The old Logic Apps-specific issue templates and support links have been removed or updated to focus on Azure Connectors and Stack Overflow. [1] [2] [3]

Minor documentation fixes:

  • Improved project structure formatting and clarified docstring sections in the README. [1] [2]

These changes ensure the SDK documentation and samples are accurate, up-to-date, and aligned with the current Azure Connectors platform.

manvkaur and others added 7 commits May 18, 2026 19:22
Port .NET SDK fix (Connectors-NET-SDK#152) to Python SDK - handles both
batch and single-item trigger callback payload shapes from Connector Namespace.

- Add from_dict/from_json class methods to TriggerCallbackBody and TriggerCallbackPayload
- Update Office365 ClientReceiveMessage.from_json for single-item shape
- Add 22 new tests covering batch and single-item payloads
- Rewrite trigger-registration skill with ConnectorTrigger extension patterns
- Update connection-setup skill with broader SDK scope and correct region

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@manvkaur manvkaur changed the title Fix single-item trigger payload handling & update skills documentation Update reference from Gateway / Logic Apps to Connector Namespace May 22, 2026
@manvkaur manvkaur marked this pull request as ready for review May 22, 2026 20:40
@manvkaur manvkaur requested a review from a team as a code owner May 22, 2026 20:40
@manvkaur manvkaur changed the title Update reference from Gateway / Logic Apps to Connector Namespace Update text references from Gateway / Logic Apps to Connector Namespace May 22, 2026
@swapnil-nagar

Copy link
Copy Markdown

PR #27 Review: Update text references from Gateway / Logic Apps to Connector Namespace

Repository: Azure/connectors-python-sdk
PR: #27
Author: @manvkaur
Branch: manvkaur/fix-single-item-trigger-payloadmain
Scope: 22 files changed, +309 / −322
CI: 14 / 14 checks passing

Summary

Documentation-only PR renaming "Connector Gateway" → "Connector Namespace" and "Azure Logic Apps" → "Azure Connectors" across docs, skills, samples, and package metadata.

Strengths

  • Consistent terminology replacement across README.md, ROADMAP.md, SKILL files, samples, and package docstrings.
  • Adds a useful Next Steps section in .github/skills/connection-setup/SKILL.md with a concrete SDK usage example.
  • README.md now references the Node.js SDK alongside the .NET SDK — good cross-SDK discoverability.
  • Adds a text language hint to a fenced code block (better Markdown rendering).
  • Cleans up obsolete Logic Apps support links in SUPPORT.md.
  • PowerShell variable rename $gatewayName$connectorNamespace is applied consistently in snippets.

Issues / Suggestions

1. ARM URI path still uses connectorGateways — inconsistent with terminology

In docs/connection-setup.md, the prose says "Connector Namespace" but ARM URIs still target providers/Microsoft.Web/connectorGateways/.... Either:

  • The resource provider truly is still connectorGateways — then add a one-line note explaining the resource type lags the branding, or
  • It should also be renamed.

The ROADMAP.md line **Transition to Connector Namespace API** (`Microsoft.Web/connectorGateways`) has the same mismatch.

2. ROADMAP self-contradiction about GA status

The PR description says the roadmap was updated "to reflect the Connector Namespace resource and its GA status," but the diff still reads:

"Available in First Release / TIP regions (as of 2026-03-05) but not yet GA."
"Blocked on: Connector Namespace reaching GA"
"Connector Namespace GA | ⬜ Not yet GA"

Either the PR description is inaccurate or the roadmap text needs updating.

3. pyproject.toml author email is stale

{ name = "Azure Connector Namespaces team at Microsoft Corp.", email = "azurelogicapps@microsoft.com" }

Display name was rebranded but the email is still azurelogicapps@. Also, "Azure Connector Namespaces team" is awkward — consider "Azure Connectors team".

4. Grammar nit: "an Connector Namespace"

Several "an Connector Gateway" → "a Connector Namespace" fixes look good. Grep the full diff once more for any remaining an Connector occurrences.

5. Sample file phrasing

Many sample files now read: "Office365 connection in Connector Namespaces" (plural). Reads awkwardly — "in a Connector Namespace" is more natural.

6. Deleted .github/ISSUE_TEMPLATE/config.yml

The PR deletes the issue template config without replacement. Confirm intentional — losing it reverts contact links / blank-issue settings to defaults. If the intent was only to drop Logic Apps Discussions links, consider keeping the file with updated links instead.

7. PR title/scope drift

The branch is named fix-single-item-trigger-payload and one commit is "Add changelog entry for single-item trigger payload fix", but the final PR scope is purely a terminology rename (the payload fix appears reverted in commit 08198fb "revert files"). Confirm no payload-fix code was unintentionally reverted, and consider squash-merging with a clean message.

8. Large trigger-registration/SKILL.md diff (+245 / −260) not rendered inline

GitHub didn't render the diff inline. Worth a careful manual pass — that's where regressions are most likely to hide.

Verdict

LGTM overall as a documentation refresh, but please address:

@daviburg

Copy link
Copy Markdown
Member

Note: The resource provider truly is still connectorGateways

@daviburg

Copy link
Copy Markdown
Member

"Azure Connector Namespaces team" is awkward — consider "Azure Connectors team".

No, Connectors team is different from the Connector Namespaces team; do not confuse the two.

@daviburg daviburg requested a review from swapnil-nagar May 26, 2026 18:52
@daviburg daviburg self-assigned this May 26, 2026
Comment thread .github/skills/connection-setup/SKILL.md Outdated
Comment thread .github/skills/trigger-registration/SKILL.md Outdated
Comment thread .github/skills/trigger-registration/SKILL.md Outdated
Comment thread .github/skills/trigger-registration/SKILL.md
Comment thread .github/skills/trigger-registration/SKILL.md Outdated
Comment thread .github/skills/trigger-registration/SKILL.md Outdated
Comment thread .github/skills/trigger-registration/SKILL.md
Comment thread .github/skills/trigger-registration/SKILL.md Outdated
Comment thread .github/skills/trigger-registration/SKILL.md Outdated
Comment thread src/pyproject.toml

@daviburg daviburg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dobby automated review posted by Swapnil appear to have a few valid clean-up points, but also some misdirection. Please perform a triage and request review again.

@daviburg daviburg assigned manvkaur and unassigned daviburg May 26, 2026
@hallvictoria hallvictoria requested a review from daviburg May 26, 2026 20:24
Comment thread .github/skills/trigger-registration/SKILL.md Outdated
@daviburg

Copy link
Copy Markdown
Member

[Dobby] The [Unreleased] section in CHANGELOG.md is empty, but this PR changes pyproject.toml metadata (author name, description, keywords) that will affect the next published PyPI package. Consider adding an entry under ## [Unreleased] / ### Changed so consumers understand why package metadata shifted — e.g. renamed package metadata from Logic Apps to Azure Connectors branding, removed logic-apps keyword.

@daviburg daviburg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only should consider a changelog entry.

@manvkaur manvkaur merged commit c87e0fe into main May 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants