fix: backport error handling fixes to existing connectors#47
Open
hallvictoria wants to merge 2 commits into
Open
fix: backport error handling fixes to existing connectors#47hallvictoria wants to merge 2 commits into
hallvictoria wants to merge 2 commits into
Conversation
…into hallvictoria/add-error-handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive error handling improvements across 14 connector clients with +205 new tests, source bug fixes, and code quality improvements.
Fixes #38, #39
Changes
Fixed
respond_to_event_asyncmethods (mypy error)ConnectorExceptionsignature in 2 webhook methods (used keyword args instead of positional)Changed
Updated
README.md— Updated test counts for 14 connectors (+205 tests total)CHANGELOG.md— Documented changes under[Unreleased]Testing
pytest)flake8 src/ tests/)Checklist
src/azure/connectors/*.py(unless regenerated)