-
Notifications
You must be signed in to change notification settings - Fork 282
[MCP] Adding delete_record #2889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+725
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-api-builder into jerry-mcp-core" This reverts commit 0b649dbbc877a8ad009ac31eb4a082664d49bce3, reversing changes made to 2240172.
## Why make this change? - Introduces a dedicated runtime layer for MCP ## What is this change? - Adds a runtime initialization module that centralizes configuration load, validation, DI registration, and service/materialization order. - Refactors existing startup code into clearer phases; removes duplicated wiring. - Improves logging structure and prepares for future feature flags / layered config overrides. - Cleans up deprecated code paths (overall net +901 / −130 LOC). - No intentional breaking changes (verify before merge). ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) - Discover tools: POST `http://localhost:5000/mcp` JSON body ``` { "jsonrpc": "2.0", "id": "1", "method": "tools/list", "params": {} } ``` - List entities: POST `http://localhost:5000/mcp` JSON body ``` { "jsonrpc": "2.0", "id": 1, "method": "tools/call", "params": { "name": "list_entities" } } ``` --------- Co-authored-by: Rahul Nishant <[email protected]> Co-authored-by: RubenCerna2079 <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]>
…ilder into jerry-mcp-core
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
3 tasks
6 tasks
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
RubenCerna2079
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments based on some necessary requirements Aniruddh and Anusha talked about. Besides that, it LGTM!
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
aaronburtle
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes on
delete_record
#2830What is this change?
This PR implements built-int tool
delete_record
as part of built-in tools to support delete operation on a table entity.How was this tested?
Functional testing using Insomnia client by running DAB in localhost and local SQL DB database
Sample Request(s)
Delete by single Primary Key
Delete by a composite key