Fix parameter ordering bug in TaskHubClient.cs#1219
Merged
Conversation
Fixed a bug in `CreateOrchestrationInstanceAsync` where the `startAt` parameter was incorrectly passed as the 8th argument to `InternalCreateOrchestrationInstanceWithRaisedEventAsync`, which expects `startAt` as the 9th parameter. Updated the method call to correctly pass `startAt` as the 9th argument, preserving the correct order of optional parameters
cgillum
approved these changes
May 21, 2025
cgillum
left a comment
cgillum
left a comment
Member
There was a problem hiding this comment.
Thanks for this fix! Indeed, it looks like this parameter was not correctly assigned (one of the reasons I wish we were using named parameters for these overloads).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in
CreateOrchestrationInstanceAsyncwhere thestartAtparameter was incorrectly passed as the 8th argument toInternalCreateOrchestrationInstanceWithRaisedEventAsync, which expectsstartAtas the 9th parameter.Updated the method call to correctly pass
startAtas the 9th argument, preserving the correct order of optional parameters