Skip to content

Commit

Permalink
Improved warnings for missing Policies in CSV file (#465)
Browse files Browse the repository at this point in the history
  • Loading branch information
techlake authored Jan 26, 2024
1 parent 6fdee01 commit 6ca2577
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Scripts/Helpers/Build-AssignmentDefinitionNode.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ function Build-AssignmentDefinitionNode {
# Ignore empty lines with a warning
$name = $row.name
if ($null -eq $name -or $name -eq "") {
Write-Warning " Node $($nodeName): CSV parameterFile '$parameterFileName' has an empty row."
Write-Verbose " Node $($nodeName): CSV parameterFile '$parameterFileName' has an empty row."
continue
}

Expand Down Expand Up @@ -264,8 +264,8 @@ function Build-AssignmentDefinitionNode {
}
else {
$flatPolicyEntry = $flatPolicyList.$flatPolicyEntryKey
if ($flatPolicyEntry.isEffectParameterized) {
# Complain only about Policies with parameterized effect value
if ($VerbosePreference -eq "Continue" -or ($flatPolicyEntry.effectDefault -ne "Manual" -and $flatPolicyEntry.effectDefault -ne "Disabled")) {
# Complain only about Policies NOT with Manual or Disabled effect default or when Verbose is on
if ($flatPolicyEntry.referencePath) {
$null = $missingInCsv.Add("$($flatPolicyEntry.displayName) ($($flatPolicyEntry.name) -- $($flatPolicyEntry.referencePath))")
}
Expand Down

0 comments on commit 6ca2577

Please sign in to comment.