update readme and rule name, fix incorrect mock data

Azure · Feb 10, 2025 · a159c79 · a159c79
1 parent abf0c17
commit a159c79
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/...oactive-Resiliency-Library-v2/azapi/network/microsoft_network_publicIPAddresses.mock.json b/...oactive-Resiliency-Library-v2/azapi/network/microsoft_network_publicIPAddresses.mock.json
@@ -47,7 +47,8 @@
                 "sku": {
                   "name": "Basic"
                 }
-              }
+              },
+              "type": "Microsoft.Network/publicIPAddresses@2024-05-01"
             }
           }
         }
@@ -71,7 +72,8 @@
                 "sku": {
                   "name": "Standard"
                 }
-              }
+              },
+              "type": "Microsoft.Network/publicIPAddresses@2024-05-01"
             }
           }
         }
@@ -96,7 +98,8 @@
                   "name": "Standard"
                 },
                 "zones": []
-              }
+              },
+              "type": "Microsoft.Network/publicIPAddresses@2024-05-01"
             }
           }
         }
@@ -121,7 +124,8 @@
                   "name": "Standard"
                 },
                 "zones": ["1"]
-              }
+              },
+              "type": "Microsoft.Network/publicIPAddresses@2024-05-01"
             }
           }
         }

diff --git a/...re-Proactive-Resiliency-Library-v2/azapi/network/microsoft_network_publicIPAddresses.rego b/...re-Proactive-Resiliency-Library-v2/azapi/network/microsoft_network_publicIPAddresses.rego
@@ -7,7 +7,7 @@ valid(resource) if {
     count(resource.values.body.zones) >= 2
 }
 
-deny_use_resilient_load_lalancer_sku contains reason if {
+deny_use_standard_sku_and_zone_redundant_ip contains reason if {
     resource := data.utils.resource(input, "azapi_resource")[_]
     data.utils.is_azure_type(resource.values, "Microsoft.Network/publicIPAddresses")
     not valid(resource)

diff --git a/...zurerm_public_ip_zone-redundant.mock.json → ...zurerm_public_ip_zone_redundant.mock.json b/...zurerm_public_ip_zone-redundant.mock.json → ...zurerm_public_ip_zone_redundant.mock.json
diff --git a/...ork/azurerm_public_ip_zone-redundant.rego → ...ork/azurerm_public_ip_zone_redundant.rego b/...ork/azurerm_public_ip_zone-redundant.rego → ...ork/azurerm_public_ip_zone_redundant.rego
@@ -7,7 +7,7 @@ valid_ip(resource) if {
    count(resource.values.zones) >= 2
 }
 
-deny_deploy_application_gateway_in_a_zone_redundant_configuration contains reason if {
+deny_use_standard_sku_and_zone_redundant_ip contains reason if {
     resource := data.utils.resource(input, "azurerm_public_ip")[_]
     not valid_ip(resource)
 

diff --git a/readme.md b/readme.md
@@ -45,6 +45,10 @@ conftest test --all-namespaces --update git::https://github.com/lonegunmanb/poli
 [`use_nat_gateway_instead_of_outbound_rules_for_production_load_lalancer`](https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/loadBalancers/#use-nat-gateway-instead-of-outbound-rules-for-production-workloads)
 [`use_resilient_load_lalancer_sku`](https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/loadBalancers/#use-standard-load-balancer-sku)
 
+* `Microsoft.Network/publicIPAddresses`
+
+[`use_standard_sku_and_zone_redundant_ip`](https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/publicIPAddresses/#use-standard-sku-and-zone-redundant-ips-when-applicable)
+
 * `Microsoft.DBforMySQL/flexibleServers`
 
 [`mysql_flexible_server_high_availability_mode_zone_redundant`](https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/DBforMySQL/flexibleServers/#enable-ha-with-zone-redundancy)