fix incorrect rule

Azure · Feb 17, 2025 · b7f105b · b7f105b
1 parent 8653c31
commit b7f105b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/...iliency-Library-v2/azurerm/compute/azurerm_linux_virtual_machine_availability_set_id.rego b/...iliency-Library-v2/azurerm/compute/azurerm_linux_virtual_machine_availability_set_id.rego
@@ -2,9 +2,17 @@ package Azure_Proactive_Resiliency_Library_v2
 
 import rego.v1
 
+valid_azurerm_deny_migrate_vm_using_availability_sets_to_vmss_flex(_resource) if {
+    not _resource.values.availability_set_id
+}
+
+valid_azurerm_deny_migrate_vm_using_availability_sets_to_vmss_flex(_resource) if {
+    _resource.values.availability_set_id == null
+}
+
 deny_migrate_vm_using_availability_sets_to_vmss_flex contains reason if {
     resource := data.utils.resource(input, "azurerm_linux_virtual_machine")[_]
-    resource.values.availability_set_id
+    not valid_azurerm_deny_migrate_vm_using_availability_sets_to_vmss_flex(resource)
 
     reason := sprintf("Azure-Proactive-Resiliency-Library-v2: '%s' `azurerm_linux_virtual_machine` must not define `availability_set_id`: https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#migrate-vms-using-availability-sets-to-vmss-flex", [resource.address])
 }
diff --git a/policy/common/common.utils.rego b/policy/common/common.utils.rego
@@ -61,4 +61,4 @@ is_create_or_update(change_actions) if {
 
 is_resource_create_or_update(resource) if {
 	is_create_or_update(resource.change.actions)
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -61,4 +61,4 @@ is_create_or_update(change_actions) if { @@
     is_resource_create_or_update(resource) if {
     	is_create_or_update(resource.change.actions)
-    }
+    }