Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule for vm's zone #28

Merged
merged 2 commits into from
Feb 20, 2025
Merged

add rule for vm's zone #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9810949
add rule for vm's zone
lonegunmanb Feb 20, 2025
cea85fb
update readme
lonegunmanb Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions ...ive-Resiliency-Library-v2/azapi/compute/microsoft_compute_virtualMachines_zones.mock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
{
"mock": {
"valid_zones": {
"resource_changes": [
{
"address": "azapi_resource.res",
"mode": "managed",
"type": "azapi_resource",
"name": "res",
"provider_name": "registry.terraform.io/azure/azapi",
"change": {
"actions": [
"create"
],
"after": {
"body": {
"zones": [
"1"
]
},
"type": "Microsoft.Compute/virtualMachines@2024-07-01"
}
}
}
]
},
"invalid_no_zones": {
"resource_changes": [
{
"address": "azapi_resource.res",
"mode": "managed",
"type": "azapi_resource",
"name": "res",
"provider_name": "registry.terraform.io/azure/azapi",
"change": {
"actions": [
"create"
],
"after": {
"body": {
},
"type": "Microsoft.Compute/virtualMachines@2024-07-01"
}
}
}
]
},
"invalid_empty_zones": {
"resource_changes": [
{
"address": "azapi_resource.res",
"mode": "managed",
"type": "azapi_resource",
"name": "res",
"provider_name": "registry.terraform.io/azure/azapi",
"change": {
"actions": [
"create"
],
"after": {
"body": {
"zones": []
},
"type": "Microsoft.Compute/virtualMachines@2024-07-01"
}
}
}
]
}
}
}
15 changes: 15 additions & 0 deletions ...roactive-Resiliency-Library-v2/azapi/compute/microsoft_compute_virtualMachines_zones.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package Azure_Proactive_Resiliency_Library_v2

import rego.v1

valid_azapi_mission_critical_virtual_machine_should_use_zone(resource) if {
count(resource.values.body.zones) > 0
}

deny_mission_critical_virtual_machine_should_use_zone contains reason if {
resource := data.utils.resource(input, "azapi_resource")[_]
data.utils.is_azure_type(resource.values, "Microsoft.Compute/virtualMachines")
not valid_azapi_mission_critical_virtual_machine_should_use_zone(resource)

reason := sprintf("Azure-Proactive-Resiliency-Library-v2/mission_critical_virtual_machine_should_use_zone: '%s' `azapi_resource` must have configured `zones`: https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#deploy-vms-across-availability-zones", [resource.address])
}
41 changes: 41 additions & 0 deletions ...active-Resiliency-Library-v2/azurerm/compute/azurerm_linux_virtual_machine_zone.mock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{
"mock": {
"valid_zone": {
"resource_changes": [
{
"address": "azurerm_linux_virtual_machine.example",
"mode": "managed",
"type": "azurerm_linux_virtual_machine",
"name": "example",
"provider_name": "registry.terraform.io/hashicorp/azurerm",
"change": {
"actions": [
"create"
],
"after": {
"zone": "1"
}
}
}
]
},
"invalid_no_zone": {
"resource_changes": [
{
"address": "azurerm_linux_virtual_machine.example",
"mode": "managed",
"type": "azurerm_linux_virtual_machine",
"name": "example",
"provider_name": "registry.terraform.io/hashicorp/azurerm",
"change": {
"actions": [
"create"
],
"after": {
}
}
}
]
}
}
}
14 changes: 14 additions & 0 deletions ...e-Proactive-Resiliency-Library-v2/azurerm/compute/azurerm_linux_virtual_machine_zone.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package Azure_Proactive_Resiliency_Library_v2

import rego.v1

valid_azurerm_linux_mission_critical_virtual_machine_should_use_zone(resource) if {
resource.values.zone == resource.values.zone
}

deny_mission_critical_virtual_machine_should_use_zone contains reason if {
resource := data.utils.resource(input, "azurerm_linux_virtual_machine")[_]
not valid_azurerm_linux_mission_critical_virtual_machine_should_use_zone(resource)

reason := sprintf("Azure-Proactive-Resiliency-Library-v2/mission_critical_virtual_machine_should_use_zone: '%s' `azurerm_linux_virtual_machine` must have configured `zone`: https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#deploy-vms-across-availability-zones", [resource.address])
}
41 changes: 41 additions & 0 deletions ...tive-Resiliency-Library-v2/azurerm/compute/azurerm_windows_virtual_machine_zone.mock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{
"mock": {
"valid_zone": {
"resource_changes": [
{
"address": "azurerm_windows_virtual_machine.example",
"mode": "managed",
"type": "azurerm_windows_virtual_machine",
"name": "example",
"provider_name": "registry.terraform.io/hashicorp/azurerm",
"change": {
"actions": [
"create"
],
"after": {
"zone": "1"
}
}
}
]
},
"invalid_no_zone": {
"resource_changes": [
{
"address": "azurerm_windows_virtual_machine.example",
"mode": "managed",
"type": "azurerm_windows_virtual_machine",
"name": "example",
"provider_name": "registry.terraform.io/hashicorp/azurerm",
"change": {
"actions": [
"create"
],
"after": {
}
}
}
]
}
}
}
14 changes: 14 additions & 0 deletions ...Proactive-Resiliency-Library-v2/azurerm/compute/azurerm_windows_virtual_machine_zone.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package Azure_Proactive_Resiliency_Library_v2

import rego.v1

valid_azurerm_windows_mission_critical_virtual_machine_should_use_zone(resource) if {
resource.values.zone == resource.values.zone
}

deny_mission_critical_virtual_machine_should_use_zone contains reason if {
resource := data.utils.resource(input, "azurerm_windows_virtual_machine")[_]
not valid_azurerm_windows_mission_critical_virtual_machine_should_use_zone(resource)

reason := sprintf("Azure-Proactive-Resiliency-Library-v2/mission_critical_virtual_machine_should_use_zone: '%s' `azurerm_windows_virtual_machine` must have configured `zone`: https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#deploy-vms-across-availability-zones", [resource.address])
}
1 change: 1 addition & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ conftest test --all-namespaces --update git::https://github.com/lonegunmanb/poli
`legacy_virtual_machine_not_allowed`
[`migrate_vm_using_availability_sets_to_vmss_flex`](https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#migrate-vms-using-availability-sets-to-vmss-flex)
[`mission_critical_virtual_machine_should_use_premium_or_ultra_disks`](https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#mission-critical-workloads-should-consider-using-premium-or-ultra-disks)
[`mission_critical_virtual_machine_should_use_zone`](https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#deploy-vms-across-availability-zones)

* `Microsoft.ContainerService/managedClusters`

Expand Down
Loading