Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proxy the old way for mdsd in golang #1062

Merged
merged 4 commits into from
Feb 19, 2025
Merged

fix: set proxy the old way for mdsd in golang #1062

merged 4 commits into from
Feb 19, 2025

Conversation

bragi92
Copy link
Member

@bragi92 bragi92 commented Feb 18, 2025

Adding in the changes for this ICM fix which was missed : https://github.com/Azure/prometheus-collector/pull/864/files

PR Description

New Feature Checklist

  • List telemetry added about the feature.
  • Link to the one-pager about the feature.
  • List any tasks necessary for release (3P docs, AKS RP chart changes, etc.) after merging the PR.
  • Attach results of scale and perf testing.

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
      • fips
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

Adding in the changes for this ICM fix which was missed : https://github.com/Azure/prometheus-collector/pull/864/files
@bragi92 bragi92 requested a review from a team as a code owner February 18, 2025 20:36
@bragi92
Copy link
Member Author

bragi92 commented Feb 18, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bragi92 bragi92 changed the title Update proxy_settings.go fix: set proxy the old way for mdsd in golang Feb 18, 2025
@bragi92
Copy link
Member Author

bragi92 commented Feb 18, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bragi92 bragi92 enabled auto-merge (squash) February 18, 2025 23:30
@bragi92 bragi92 merged commit 5571153 into main Feb 19, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants