Skip to content

Commit

Permalink
add switch on whether to create role assignments for hci rp (#31)
Browse files Browse the repository at this point in the history
Co-authored-by: Zidong Lu <[email protected]>
  • Loading branch information
xhy8759 and duzitong authored Nov 21, 2024
1 parent 4e721ff commit 6f1687f
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,14 @@ Type: `string`

Default: `"Express"`

### <a name="input_create_hci_rp_role_assignments"></a> [create\_hci\_rp\_role\_assignments](#input\_create\_hci\_rp\_role\_assignments)

Description: Indicates whether to create role assignments for the HCI resource provider service principal.

Type: `bool`

Default: `false`

### <a name="input_create_key_vault"></a> [create\_key\_vault](#input\_create\_key\_vault)

Description: Set to true to create the key vault, or false to skip it
Expand Down
4 changes: 2 additions & 2 deletions locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,9 @@ locals {
roles = {
KVSU = "Key Vault Secrets User",
}
rp_roles = {
rp_roles = var.create_hci_rp_role_assignments ? {
ACMRM = "Azure Connected Machine Resource Manager",
}
} : {}
secrets_location = var.secrets_location == "" ? local.key_vault.vault_uri : var.secrets_location
seperate_intents = [{
name = var.compute_intent_name,
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,12 @@ variable "configuration_mode" {
description = "The configuration mode for the storage."
}

variable "create_hci_rp_role_assignments" {
type = bool
default = false
description = "Indicates whether to create role assignments for the HCI resource provider service principal."
}

variable "create_key_vault" {
type = bool
default = true
Expand Down

0 comments on commit 6f1687f

Please sign in to comment.