parse_resource_id should not accepet nullable input (#593)

* `parse_resource_id` should not accepet nullable input * update testcase
Azure · Aug 29, 2024 · 374779f · 374779f
1 parent 2cde423
commit 374779f
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 26 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,15 @@ BREAKING CHANGES:
 - The `body` field now only accepts an HCL object. Please remove the `jsondecode` function when using the `body` field.
 - The `output` field now only exports an HCL object. Please remove the `jsondecode` function when using the `output` field.
 
+FEATURES:
+- **New Provider Function**: build_resource_id
+- **New Provider Function**: parse_resource_id
+- **New Provider Function**: subscription_resource_id
+- **New Provider Function**: tenant_resource_id
+- **New Provider Function**: management_group_resource_id
+- **New Provider Function**: resource_group_resource_id
+- **New Provider Function**: extension_resource_id
+
 ENHANCEMENTS:
 - `azapi_resource` resource: Support `replace_triggers_external_values` field which is used to trigger a replacement of the resource.
 - `azapi` resources and data sources: Support `retry` field, which is used to specify the retry configuration.

diff --git a/docs/functions/parse_resource_id.md b/docs/functions/parse_resource_id.md
@@ -30,7 +30,7 @@ locals {
 #     "virtualNetworks" = "myVNet"
 #   })
 #   "provider_namespace" = "Microsoft.Network"
-#   "resource_gr  oup_name" = "myResourceGroup"
+#   "resource_group_name" = "myResourceGroup"
 #   "subscription_id" = "00000000-0000-0000-0000-000000000000"
 #   "type" = "Microsoft.Network/virtualNetworks"
 # }
@@ -50,5 +50,5 @@ parse_resource_id(resource_type string, resource_id string) object
 
 <!-- arguments generated by tfplugindocs -->
 1. `resource_type` (String) The resource type of the Azure resource.
-1. `resource_id` (String, Nullable) The resource ID of the Azure resource to parse.
+1. `resource_id` (String) The resource ID of the Azure resource to parse.
 
diff --git a/examples/functions/parse_resource_id/function.tf b/examples/functions/parse_resource_id/function.tf
@@ -15,7 +15,7 @@ locals {
 #     "virtualNetworks" = "myVNet"
 #   })
 #   "provider_namespace" = "Microsoft.Network"
-#   "resource_gr  oup_name" = "myResourceGroup"
+#   "resource_group_name" = "myResourceGroup"
 #   "subscription_id" = "00000000-0000-0000-0000-000000000000"
 #   "type" = "Microsoft.Network/virtualNetworks"
 # }

diff --git a/internal/services/functions/parse_resource_id_function.go b/internal/services/functions/parse_resource_id_function.go
@@ -45,8 +45,8 @@ func (p *ParseResourceIdFunction) Definition(ctx context.Context, request functi
 				MarkdownDescription: "The resource type of the Azure resource.",
 			},
 			function.StringParameter{
-				AllowNullValue:      true,
-				AllowUnknownValues:  true,
+				AllowNullValue:      false,
+				AllowUnknownValues:  false,
 				Name:                "resource_id",
 				Description:         "The resource ID of the Azure resource to parse.",
 				MarkdownDescription: "The resource ID of the Azure resource to parse.",
@@ -70,16 +70,6 @@ func (p *ParseResourceIdFunction) Run(ctx context.Context, request function.RunR
 		return
 	}
 
-	if resourceId.IsNull() {
-		response.Error = response.Result.Set(ctx, types.ObjectNull(ParseResourceIdResultAttrTypes))
-		return
-	}
-
-	if resourceId.IsUnknown() {
-		response.Error = response.Result.Set(ctx, types.ObjectUnknown(ParseResourceIdResultAttrTypes))
-		return
-	}
-
 	resourceType := utils.TryAppendDefaultApiVersion(resourceTypeParam)
 
 	id, err := parse.ResourceIDWithResourceType(resourceId.ValueString(), resourceType)

diff --git a/internal/services/functions/parse_resource_id_function_test.go b/internal/services/functions/parse_resource_id_function_test.go
@@ -148,17 +148,6 @@ func TestParseResourceIdFunction(t *testing.T) {
 				Result: function.NewResultData(types.ObjectUnknown(functions.ParseResourceIdResultAttrTypes)),
 			},
 		},
-		"unknown-resource-id": {
-			request: function.RunRequest{
-				Arguments: function.NewArgumentsData([]attr.Value{
-					types.StringValue("Microsoft.Network/virtualNetworks"),
-					types.StringUnknown(),
-				}),
-			},
-			expected: function.RunResponse{
-				Result: function.NewResultData(types.ObjectUnknown(functions.ParseResourceIdResultAttrTypes)),
-			},
-		},
 	}
 
 	for name, testCase := range testCases {