feat: Provider functions to build azure resource id #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hqhqhqhqhqhqhqhqhqhqhq
force-pushed
the
feature-provider-function
branch
3 times, most recently
from
9894ebf to
002524d
Compare
Create main.yml Update codeql.yaml Update main.yml Update main.yml Update main.yml Update main.yml Update main.yml
This reverts commit e8701ff.
ms-henglu
changed the base branch from
feature-provider-function
to
feature-two-point-oh
ms-henglu
requested changes
Aug 9, 2024
internal/services/functions/build_extension_scope_resource_id.go
Outdated
Show resolved
Hide resolved
internal/services/functions/build_extension_scope_resource_id.go
Outdated
Show resolved
Hide resolved
internal/services/functions/build_subscription_scope_resource_id_test.go
Outdated
Show resolved
Hide resolved
hqhqhqhqhqhqhqhqhqhqhq
force-pushed
the
feature-provider-function
branch
from
7f53aec to
02953e2
Compare
ms-henglu
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Thanks @hqhqhqhqhqhqhqhqhqhqhq for the PR! It mostly LGTM, just some minor suggestions. Once they're addressed, I'll merge this PR.
| ```terraform | ||
| locals { | ||
| resource_id = "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet1" | ||
| extension_name = "Microsoft.Authorization/locks" |
There was a problem hiding this comment.
I guess it's a typo, it should be "resource_type"?
| @@ -0,0 +1,216 @@ | |||
| --- | |||
There was a problem hiding this comment.
I think we don't need this doc, because we have docs for each provider function.
| } | ||
|
|
||
| output "resource_id" { | ||
| value = provider::azapi::build_resource_id(local.parent_id, local.resource_type, local.name) |
There was a problem hiding this comment.
Please add a comment which shows the result of the provider function, it will help users understand how it works. And please also update other places.
|
And please also resolve the conflicts. |
hqhqhqhqhqhqhqhqhqhqhq
force-pushed
the
feature-provider-function
branch
from
c01626e to
041978b
Compare
Required changes have been made, please review when available, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of https://github.com/Azure/terraform-provider-azapi/issues/533>
Several functions are provided to build resource id of different scope
build_resource_idwithparent_id,type,namebuild_tenant_scope_resource_idwithtype,namebuild_management_group_scope_resource_idwithmanagement_group_id,type,namebuild_subscription_scope_resource_idwithsubscription_id,type,namebuild_resource_group_scope_resource_idwithsubscription_id,resource_group_name,type,name