feat: azapi_client_config - add object id #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-henglu
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks @matt-FFFFFF for this PR. It mostly LGTM, just some minor comments, please check.
|
Hi @ms-henglu I have updated this and responded to your comments. Please can you review again? Thanks! |
ms-henglu
requested changes
Nov 15, 2024
internal/clients/account.go
Outdated
| log.Printf("[DEBUG] Error getting requesting token from credentials: %s", err) | ||
| } | ||
|
|
||
| cl, err := parseTokenClaims(tok.Token) |
There was a problem hiding this comment.
Do we need a nil-check on the tok? If above GetToken returns error, the tok could be nil here?
There was a problem hiding this comment.
tok is of type AccessToken. This is a value type not a pointer.
The type declaration is:
type AccessToken struct {
Token string
ExpiresOn time
}I refactored using a comparison of tok.Token == "" as this will be the default value if the token request fails.
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the gap to the azurerm equivalent by adding the
object_idattribute to theazapi_client_configresource.Also adds a convenience attribute to azapi_client_config to allow for adding the subscription resource id easily into
parent_id.@ms-henglu