-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve retry behavior with resources at MG scope #681
Conversation
Hi @matt-FFFFFF , Thank you for the PR, LGTM.
I think it's better to allow the user specified |
541bf1e
to
e839466
Compare
Hi @ms-henglu I have rebased and updated this PR to pass the regex messages to the getafterput client. The max time was omitted from the retry object because we rely on the resource timeout value (context deadline). I think having two timeouts could be confusing? WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, LGTM.
As per internal thread:
I could also pass the regex to the get after put retry, but since the body is nil then the retry func catches the issue where we get a 403. WDYT @ms-henglu