Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: query parameters and headers don't work properly with unknown values #714

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ms-henglu
Copy link
Member

fixes #711

@ms-henglu ms-henglu requested a review from magodo January 9, 2025 07:08
Copy link
Contributor

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we state this is a limitation, instead of silently ignore them and return empty query/header? Ideally, I think we shall split the header/query between different operations, e.g. read_header, create_header, etc.

@ms-henglu
Copy link
Member Author

Shall we state this is a limitation, instead of silently ignore them and return empty query/header? Ideally, I think we shall split the header/query between different operations, e.g. read_header, create_header, etc.

We only convert the headers/query parameters from types.Map to go type in the CRUD functions, these values must be known at that time.

@ms-henglu ms-henglu merged commit 695e646 into main Jan 10, 2025
8 of 10 checks passed
@ms-henglu ms-henglu deleted the issue711 branch January 10, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] azapi_* cannot support query parameters of unknown type
2 participants