bugfix: format azurerm resource ID when move resource #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magodo
reviewed
Mar 4, 2025
| func AzurermIdToAzureId(azurermResourceType string, azurermId string) (string, error) { | ||
| switch azurermResourceType { | ||
| case "azurerm_monitor_diagnostic_setting": | ||
| // input: <target id>|<diagnostic setting name> |
There was a problem hiding this comment.
There are a couple of these unsual resource id in azurerm, is there a plan to handle them comprehensively?
There was a problem hiding this comment.
Yes, I did check all the unusual resource IDs from aztft, but most of them are associations or part of a resource, the ID could be parsed to an azure resource ID correctly, so I didn't handle them.
I'll keep adding more similar cases here.
magodo
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #704