feat: support non-root user #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging this pr whilst trivy check failed. I'll fix trivy issues later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running as non-root user. It corrects some errors with the go installation.
It will enable us to modify the avm script file to pass in the current user/group.
This will resolve local permissions errors running the container on a developer machine. Currently any files created whilst in the container are owned by
root:root.After this is merged we will pass in
--user "$(id -u):$(id -g)"to the docker command to run as the current user. We could also optionally mount /etc/passwd to allow correct user mapping.We will ask developers to run the following command to fix any files owned by root:
find -user 0 | xargs sudo chown "$(id -u):$(id -g)"It also bumps TF to 1.8.2 and removes some unused ARGS.