Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify and optimise #43

Merged
merged 1 commit into from
May 15, 2024
Merged

feat: simplify and optimise #43

merged 1 commit into from
May 15, 2024

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented May 15, 2024 •
edited
Loading

Dockerfile

  • removes unused stuff
  • Correctly sets $HOME
  • Plugin cache dir set

Scripts

  • New clean script to ensure sane environment prior to running tests and to tidy up afterwards

Makefile

  • clean target (and clean2) so we can ensure sane environment and clean up afterwards

@matt-FFFFFF matt-FFFFFF merged commit 3fd47af into main May 15, 2024
2 checks passed
@matt-FFFFFF matt-FFFFFF deleted the feat/simplifyandoptimise branch May 15, 2024 11:14
jaredfholgate
jaredfholgate reviewed May 15, 2024
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments / questions.

@jaredfholgate
Copy link
Member

Oops, too late! :)

@matt-FFFFFF
Copy link
Member Author

Sorry. Good comments - responded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredfholgate jaredfholgate jaredfholgate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-FFFFFF @jaredfholgate