Add WAF rules and update version #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredfholgate
changed the title
matt-FFFFFF
approved these changes
Jun 26, 2024
Comment on lines
+194
to
+259
|
|
||
| # AVM WAF Rules | ||
|
|
||
| rule "azurerm_application_gateway.zones" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_application_gateway.sku.name" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_cosmosdb_account.backup.type" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_kubernetes_cluster.zones" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_lb.sku" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_mysql_flexible_server.high_availability.mode" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_mysql_flexible_server.maintenance_window.day_of_week" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_postgresql_flexible_server.high_availability.mode" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_postgresql_flexible_server.maintenance_window.day_of_week" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_public_ip.sku" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_public_ip.zones" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_service_plan.zone_balancing_enabled" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_storage_account.account_replication_type" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_virtual_machine.zone" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_virtual_machine.zones" { | ||
| enabled = true | ||
| } | ||
|
|
||
| rule "azurerm_virtual_network_gateway.sku" { | ||
| enabled = true | ||
| } |
There was a problem hiding this comment.
Do we need these entries? they are enabled by default
There was a problem hiding this comment.
We don't need them, you are correct.
We just don't have any other method to easily identify the names of these rules. Putting them here makes it easier to make changes if you need to turn them off, etc. Admittedly that is an advanced use case and requires some overhead to maintain this.
If we can automate the generation of these from the avm tflint plugin and add to the read me or similar, then this would not be needed. I can look into this alternative when I have some time.
| @@ -190,3 +190,69 @@ rule "role_assignments" { | |||
| rule "tags" { | |||
| enabled = false | |||
| } | |||
|
|
|||
| @@ -191,3 +191,69 @@ rule "role_assignments" { | |||
| rule "tags" { | |||
| enabled = true | |||
| } | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest avm tflint version.
It also lists out the WAF rules for easy reference moving forward.