Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the client generation document to provide valid typespec samples #2237

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update the client generation document to provide valid typespec samples #2237

wants to merge 4 commits into from

Conversation

lirenhe
Copy link
Member

@lirenhe lirenhe commented Feb 20, 2025

Update the below 2 documents to validate all existing typespec samples

  1. Remove the pattern that we do not support.
  2. Remove the TypeSpec code that would cause lint error.
  3. Update the code to include model to make a valid sample
  4. Update the related generated code.

@lirenhe lirenhe requested a review from Copilot February 20, 2025 08:31
Copilot
Copilot AI reviewed Feb 20, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • website/src/content/docs/docs/howtos/Generate client libraries/06types.mdx: Language not supported
  • website/src/content/docs/docs/howtos/Generate client libraries/08methodInputs.mdx: Language not supported
@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 20, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website

@markcowl markcowl added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lirenhe @azure-sdk @markcowl