Fix common-types specification differences with azure-rest-api-specs #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlitzelMendez
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
ValidatationCurrently under performance, still need to do some fixes
Fix to get in after merge |
markcowl
reviewed
Mar 6, 2025
| @@ -6,34 +6,6 @@ | |||
| }, | |||
| "paths": {}, | |||
| "definitions": { | |||
| "CustomerManagedKeyEncryption": { | |||
There was a problem hiding this comment.
I'm not convinced we want to make these changes to capitalization fo schema for a few reasons:
- They have no impact on the API on the wire, they only impact swagger references
- Clients should always use their own naming schemes for their particular language when naming common-types
I would want to see a compelling reason for capitalization-only changes in schema names
| @@ -6,8 +6,8 @@ namespace Azure.ResourceManager; | |||
| alias InfrastructureEncryption = CommonTypes.InfrastructureEncryption; | |||
| alias KeyEncryptionIdentity = CommonTypes.KeyEncryptionKeyIdentity; | |||
| alias KeyEncryptionKeyIdentity = CommonTypes.KeyEncryptionKeyIdentity; | |||
| alias CustomerManagedKeyEncryption = CommonTypes.CustomerManagedKeyEncryption; | |||
| alias EncryptionConfiguration = CommonTypes.Encryption; | |||
| alias CustomerManagedKeyEncryption = CommonTypes.customerManagedKeyEncryption; | |||
There was a problem hiding this comment.
Just reiterating the comment above. This is perpetuating a bug that does not impact the wire API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will be probably doing a similar pr like this next sprint as there are still couple of differences that I am working trough, but this is some of the feedback provided in: Azure/azure-rest-api-specs#32562
TODO: Validate azure-rest-api-specs